When execute npm run watch I'm expecting that on every changes on scss files the css file will be compiled.
This don't happen, why?

CommentFileSizeAuthor
#8 2020-02-21_08-17-00.png210.86 KBdanny englander
#7 typographyimport-3054872-7.patch456 bytesPremanshu

Comments

maio1980 created an issue. See original summary.

maio1980’s picture

maio1980 commented
Issue summary: View changes
maio1980’s picture

maio1980 commented

Problem solved...
I have build a child theme with the drush script...
In my test I have try to change only one file src/sass/base/_typography.scss and this file is not present in the main style.scss...

Please update radix/src/kits/default/src/sass/default.style.scss to import _typography.scss

maio1980’s picture

maio1980 commented
Title: laravel-mix don't compile scss on file changes » typography.scss in child theme was not imported in default.style.scss
Component: Documentation » Code
Category: Support request » Bug report
shadcn’s picture

shadcn commented
Assigned: Unassigned » shadcn
Status: Active » Needs work

Woah nice catch!

Premanshu’s picture

Premanshu commented
Assigned: shadcn » Premanshu
Premanshu’s picture

Premanshu commented
Status: Needs work » Needs review
Issue tags: +Novice
StatusFileSize
new typographyimport-3054872-7.patch456 bytes

This patch fixes the problem and imports the _typography.scss file.

Note: Only the SASS structure is provided so that it is easier to use. The use and number of files is not restricted and if a file is not being used you can choose to remove it and it's import.

danny englander’s picture

danny englander
(he/him)
commented
StatusFileSize
new 2020-02-21_08-17-00.png210.86 KB

I tested the patch in the following way:

  • Installed Radix via composer
  • Enabled the theme
  • Added the patch to composer:
    "patches": {
      "drupal/radix": {
        "typography.scss in child theme was not imported in default.style.scss": "https://www.drupal.org/files/issues/2019-11-28/typographyimport-3054872-7.patch"
      }
  • Installed the patch
  • Looked in web/themes/contrib/radix/src/kits/default/src/sass/default.style.scss and it now contains @import "base/typography"
  • Created a sub-theme: drush --include="web/themes/contrib/radix" radix:create test_theme
  • Looked in the sub-theme for the presence of "typography.scss"

screen capture of the patch

danny englander’s picture

danny englander
(he/him)
commented
Status: Needs review » Reviewed & tested by the community

  • arshadcn committed fce19a0 on 8.x-4.x authored by Premanshu 
    Issue #3054872 by Premanshu, Danny Englander: typography.scss in child...
shadcn’s picture

shadcn commented
Status: Reviewed & tested by the community » Fixed

Committed. Thanks everyone.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.