Problem/Motivation

entity_clone.settings.schema.yml contains a list of known entity types. However, this schema does not cover any additional entity types that are installed through contrib modules.

Proposed resolution

Update entity_clone.settings.schema.yml to cover all entity types.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

idebr created an issue. See original summary.

idebr’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new1.11 KB
new4.27 KB

Attached patch implements a config type entity_clone.entity_type.settings and applies it to the existing entity_clone.settings. The data model remains the same.

The last submitted patch, 2: 3053099-2-test-only.patch, failed testing. View results

lamp5’s picture

Status: Needs review » Reviewed & tested by the community

Works well, thx! :)

lamp5’s picture

StatusFileSize
new3.83 KB

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 5: entity_clone-config_schema-3053099-5.patch, failed testing. View results

sorlov’s picture

Version: 8.x-1.x-dev » 2.x-dev
Status: Needs work » Needs review
StatusFileSize
new3.89 KB

Rerolled patch for 2.x

heddn’s picture

Status: Needs review » Reviewed & tested by the community
heddn’s picture

Status: Reviewed & tested by the community » Needs work
+++ b/tests/src/Kernel/EntityCloneEntityTypeSettingsTest.php
@@ -0,0 +1,36 @@
+    $entity_clone_settings->set('form_settings', $form_settings)->save();

The test should add an assert. Something like the following would probably be enough:

    try {
      $result = $this->configImporter()->validate();
      $this->assertInstanceOf(ConfigImporter::class, $result);
    }
    catch (ConfigImporterException $e) {
      $this->fail('A ConfigImporterException was thrown. This should not happen.');
    }

Rajeshreeputra made their first commit to this issue’s fork.

heddn’s picture

The MR is simply a rehash of the latest patch. Can we add the requested test coverage too?

sorlov’s picture

Added assertion to EntityCloneEntityTypeSettingsTest but now got it failed

deaom made their first commit to this issue’s fork.

deaom’s picture

Status: Needs work » Needs review

Updated the test and re-based the branch. Tests are passing, setting status to needs review.

mably’s picture

Interested in having this merged.

rajeshreeputra’s picture

Status: Needs review » Fixed

Merged!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.