Deprecate drupal_installation_attempted()

Rerolled
Replaced calls that were left.

Blocker for #3000229: Move error handlers to an Error class

Looks ready

+++ b/core/includes/bootstrap.inc
@@ -750,14 +751,15 @@ function drupal_maintenance_theme() {
+ * @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.

+++ b/core/lib/Drupal/Core/Config/ConfigInstaller.php
@@ -701,9 +702,17 @@ protected function drupalGetProfile() {
+   * @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.

+++ b/core/lib/Drupal/Core/Form/FormSubmitter.php
@@ -147,9 +148,17 @@ public function redirectForm(FormStateInterface $form_state) {
+   * @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.

Hi, we need deprecation tests for at least drupal_installation_attempted, the others are a bit trickier because they're protected.

Other than that, looks good!

Here the legacy test.

Looking good! Just a couple of nits:

1. +++ b/core/includes/bootstrap.inc
   @@ -750,14 +751,15 @@ function drupal_maintenance_theme() {
   + * @deprecated in drupal:8.8.0 and is removed from drupal:9.0.0.
   + * Use \Drupal\Core\Installer\InstallerKernel::installationAttempted() instead.
   

   Nit: indentation.

2. +++ b/core/lib/Drupal/Core/Form/FormSubmitter.php
   @@ -147,9 +148,17 @@ public function redirectForm(FormStateInterface $form_state) {
   +    @trigger_error(__NAMESPACE__ . '::drupalInstallationAttempted() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Installer\InstallerKernel::installationAttempted() instead. See https://www.drupal.org/node/3035275', E_USER_DEPRECATED);
   

   You can just use __METHOD__ to get the same result.

3. +++ b/core/lib/Drupal/Core/Installer/InstallerKernel.php
   @@ -66,4 +66,19 @@ public function getInstallProfile() {
   +    return isset($GLOBALS['install_state']) && empty($GLOBALS['install_state']['installation_finished']);
   

   It's a shame we can't replace these globals? Is there another issue for that?

#11.1 - fixed
#11.2 - thanks, changed
#11.3 - that is out of scope of this issue. There are no specific issue exist for used globals, but there are few issues where replace other existing globals with alternative storage.

Non-relative fail

Lgtm

The follow-up is #1530756: [meta] Use a proper kernel for the installer - long standing open issue to get rid of said globals in the installer.

Confirmed that the new test is running.

Committed 2732b8e and pushed to 8.8.x. Thanks!

Published the change record.

Onwards and upwards 🚀

+++ b/core/lib/Drupal/Core/Config/ConfigInstaller.php
@@ -701,9 +702,17 @@ protected function drupalGetProfile() {
+   * @see https://www.drupal.org/node/3035275
...
+    @trigger_error(__METHOD__ . '() is deprecated in drupal:8.8.0 and is removed from drupal:9.0.0. Use \Drupal\Core\Installer\InstallerKernel::installationAttempted() instead. See https://www.drupal.org/node/3035275', E_USER_DEPRECATED);

+++ b/core/lib/Drupal/Core/Form/FormSubmitter.php
@@ -147,9 +148,17 @@ public function redirectForm(FormStateInterface $form_state) {
+   * @see https://www.drupal.org/node/3035275

This is a pointed to the wrong change record. Should be https://www.drupal.org/node/3052704

Opening a new issue: #3098521: drupal_installation_attempted() deprecation referencing wrong change record