Problem/Motivation

The entityManager is deprecated

Proposed resolution

Replace deprecated service entityManager in WebformSubmissionForm

CommentFileSizeAuthor
#17 3051715-17.patch888 bytesjrockowitz
#6 webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-6-D8.patch7.62 KBthalles
#2 webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-2-D8.patch3.76 KBthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-2-D8.patch3.76 KB

Follow the patch!

Status: Needs review » Needs work

The last submitted patch, 2: webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-2-D8.patch, failed testing. View results

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Needs work

We should also update related submission forms which are using the deprecated service entityManager.

  • \Drupal\webform\WebformSubmissionForm
  • \Drupal\webform\WebformSubmissionNotesForm
  • \Drupal\webform\Form\WebformSubmissionDeleteForm
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-6-D8.patch7.62 KB

Done!

Status: Needs review » Needs work

The last submitted patch, 6: webform-Replace_deprecated_service_entityManager_in_WebformSubmissionForm-3051715-6-D8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz commented

This need to committed once 8.6.x+ is the only support core release

jrockowitz’s picture

jrockowitz commented
Title: Replace deprecated service entityManager in WebformSubmissionForm » [Drupal 8.6.x] Replace deprecated service entityManager in WebformSubmissionForm
Status: Needs review » Postponed
jrockowitz’s picture

jrockowitz commented
Status: Postponed » Needs review

Now that Drupal 8.5.x is no longer supported this should be committed.

jrockowitz’s picture

jrockowitz commented
Status: Needs review » Needs work

Tests for the patch from #6 are not passing in Drupal 8.6.x.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Reviewed & tested by the community
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

😀 How did you pass this test? 😀

jrockowitz’s picture

jrockowitz commented

I think the 8.7.x patch that I accidentally committed and the reverted broke the tests.

jrockowitz’s picture

jrockowitz commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new 3051715-17.patch888 bytes

Rerolling patch after #2985600: [Drupal 8.6.x] EntityManager has been split into 11 classes was committed.

  • jrockowitz committed 0cd0d2e on 8.x-5.x 
    Issue #3051715 by thalles, jrockowitz: [Drupal 8.6.x] Replace deprecated...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.