This issue is for testing coding standards patches before committing.

Comments

TR created an issue. See original summary.

tr’s picture

Status: Active » Needs review
StatusFileSize
new1.07 KB

Quote strings in .yml

  • TR committed b4090b9 on 8.x-1.x
    Issue #3051208-2 by TR: Coding standards
    
tr’s picture

StatusFileSize
new8.62 KB

Documentation comments and @todo

  • TR committed 329d4a1 on 8.x-1.x
    Issue #3051208-4 by TR: Coding standards
    
tr’s picture

StatusFileSize
new1.91 KB

Whitespace.

  • TR committed 0f320ca on 8.x-1.x
    Issue #3051208-6 by TR: Coding standards - whitespace
    
tr’s picture

StatusFileSize
new2.05 KB

Typehints.

  • TR committed 0e0d4a8 on 8.x-1.x
    Issue #3051208-8 by TR: Coding standards - typehints
    
tr’s picture

StatusFileSize
new605 bytes

Use implode() instead of join().

  • TR committed 52d62e5 on 8.x-1.x
    Issue #3051208-10 by TR: Coding standards - Use implode() instead of...
tr’s picture

StatusFileSize
new404 bytes

Unused use.

  • TR committed 05c0d9f on 8.x-1.x
    Issue #3051208-12 by TR: Coding standards - unused use.
    
tr’s picture

StatusFileSize
new3.65 KB

mimemail.module: Use ' instead of " where appropriate, add @file

  • TR committed 40a0942 on 8.x-1.x
    Issue #3051208-14 by TR: Coding standards
    
tr’s picture

StatusFileSize
new3.5 KB

More whitespace and line wrapping.

  • TR committed 8ed86a9 on 8.x-1.x
    Issue #3051208-16 by TR: Coding standards - more whitespace and line...
tr’s picture

StatusFileSize
new2.03 KB

Miscellaneous coding standards fixes.

  • TR committed 7756f75 on 8.x-1.x
    Issue #3051208-18 by TR: Coding standards
    
tr’s picture

Status: Needs review » Fixed

I believe all the remaining coding standards warnings are either false positives or do not need to be / should not be fixed. (For example, we don't want to and should not re-wrap all the lines in CHANGELOG.txt just because many are > 80 characters.)

So I'm going to mark this issue as fixed. If there are additional coding standards problems that need to be addressed please open a new issue for each one.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.