Drupal 9 Deprecated Code Report [#3051118]

drupal-check against mass_contact-8.x-1.x-dev (4 Feb 2019)


 ------ -------------------------------------------------------- 
  Line   mass_contact.install                                    
 ------ -------------------------------------------------------- 
  15     Call to deprecated function entity_get_form_display().  
 ------ -------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   mass_contact.module                             
 ------ ------------------------------------------------ 
  62     Call to deprecated method l() of class Drupal.  
  63     Call to deprecated method l() of class Drupal.  
  64     Call to deprecated method l() of class Drupal.  
  65     Call to deprecated method l() of class Drupal.  
 ------ ------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   src/Form/CategoryDeleteForm.php                    
 ------ --------------------------------------------------- 
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CategoryForm.php                          
 ------ --------------------------------------------------- 
  128    Call to deprecated function drupal_set_message().  
  134    Call to deprecated function drupal_set_message().  
  138    Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/MassContactMessageConfirmForm.php         
 ------ --------------------------------------------------- 
  285    Call to deprecated function drupal_set_message().  
  292    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/AdminSettingsFormTest.php                               
 ------ ----------------------------------------------------------------------- 
  14     Class Drupal\mass_contact\Tests\Form\AdminSettingsFormTest extends     
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  27     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/EmailBodyFormTest.php                                   
 ------ ----------------------------------------------------------------------- 
  13     Class Drupal\mass_contact\Tests\Form\EmailBodyFormTest extends         
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  26     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/EmailHeaderFormTest.php                                 
 ------ ----------------------------------------------------------------------- 
  14     Class Drupal\mass_contact\Tests\Form\EmailHeaderFormTest extends       
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  27     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
  33     Call to deprecated method strtolower() of class                        
         Drupal\Component\Utility\Unicode.                                      
 ------ ----------------------------------------------------------------------- 

 ------ ------------------------------------------------- 
  Line   tests/src/Functional/Form/CategoryFormTest.php   
 ------ ------------------------------------------------- 
  43     Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
  94     Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
 ------ ------------------------------------------------- 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/CategoryAccessControlHandlerTest.php                   
 ------ ------------------------------------------------------------------------ 
  16     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\CategoryAccessControlHandlerTest.      
 ------ ------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Functional\MassContactTestBase)  
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                            
         Drupal\Component\Utility\Unicode.                                                                                          
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\CategoryAccessControlHandlerTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  21     Call to deprecated method strtolower() of class                                                                                     
         Drupal\Component\Utility\Unicode.                                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\Entity\MassContactCategoryTest)  
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                                   
         Drupal\Component\Utility\Unicode.                                                                                                 
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\MassContactTest)  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                    
         Drupal\Component\Utility\Unicode.                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\OptOutTest)  
 ------ -------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                               
         Drupal\Component\Utility\Unicode.                                                                             
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\PermissionsTest)  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                    
         Drupal\Component\Utility\Unicode.                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/Entity/MassContactCategoryTest.php                     
 ------ ------------------------------------------------------------------------ 
  20     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\Entity\MassContactCategoryTest.        
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/MassContactTest.php                                    
 ------ ------------------------------------------------------------------------ 
  18     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\MassContactTest.                       
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/OptOutTest.php                                         
 ------ ------------------------------------------------------------------------ 
  18     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\OptOutTest.                            
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------- 
  Line   tests/src/Kernel/Plugin/MassContact/GroupingMethod/RoleTest.php          
 ------ ------------------------------------------------------------------------- 
  19     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class   
         Drupal\Tests\mass_contact\Kernel\Plugin\MassContact\GroupingMethod\Role  
         Test.                                                                    
 ------ ------------------------------------------------------------------------- 

                                                                                
 [ERROR] Found 31 errors

Comment	File	Size	Author
#7	interdiff-3051118-4-7.txt	1004 bytes	-enzo-
#7	drupal_9_deprecated_code-3051118-7.patch	19.4 KB	-enzo-
#4	drupal_9_deprecated_code-3051118-4.patch	18.29 KB	sergiu stici
#2	drupal_9_deprecated_code-3051118-2.patch	11.45 KB	sergiu stici

Comments

Comment #1

26 April 2019 at 22:30

waverate created an issue. See original summary.

Comment #2

sergiu stici commented 30 April 2019 at 07:55

Status:

Active

» Needs review

Status	File	Size
new	drupal_9_deprecated_code-3051118-2.patch	11.45 KB

Here is the patch, please review.

Comment #3

30 April 2019 at 07:59

Status:

Needs review

» Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3051118-2.patch, failed testing. View results

Comment #4

sergiu stici commented 30 April 2019 at 08:30

Status:

Needs work

» Needs review

Status	File	Size
new	drupal_9_deprecated_code-3051118-4.patch	18.29 KB

Comment #5

30 April 2019 at 08:34

Status:

Needs review

» Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3051118-4.patch, failed testing. View results

Comment #6

waverate commented 30 April 2019 at 12:19

drupal-check against mass_contact-8.x-1.x-dev (4 Feb 2019) with patch at #4 applied.

Still has a few errors:


 ------ -------------------------------------------- 
  Line   src/Tests/Form/AdminSettingsFormTest.php    
 ------ -------------------------------------------- 
  27     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

 ------ -------------------------------------------- 
  Line   src/Tests/Form/EmailBodyFormTest.php        
 ------ -------------------------------------------- 
  26     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

 ------ -------------------------------------------- 
  Line   src/Tests/Form/EmailHeaderFormTest.php      
 ------ -------------------------------------------- 
  26     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

                                                                                
 [ERROR] Found 3 errors

Comment #7

-enzo- commented 13 November 2019 at 03:53

Status	File	Size
new	drupal_9_deprecated_code-3051118-7.patch	19.4 KB
new	interdiff-3051118-4-7.txt	1004 bytes

Hi @waverate

After the test, the patch with a current branch only was error remains, I did a fix for that and all looks ok now.

Comment #8

-enzo- commented 13 November 2019 at 03:53

Status:

Needs work

» Needs review

Comment #9

gaurav.kapoor commented 2 July 2020 at 07:32

Status:

Needs review

» Closed (duplicate)

Drupal 9 Deprecated Code Report

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

News items

Our community

Documentation

Drupal code base

Governance of community