drupal-check against mass_contact-8.x-1.x-dev (4 Feb 2019)


 ------ -------------------------------------------------------- 
  Line   mass_contact.install                                    
 ------ -------------------------------------------------------- 
  15     Call to deprecated function entity_get_form_display().  
 ------ -------------------------------------------------------- 

 ------ ------------------------------------------------ 
  Line   mass_contact.module                             
 ------ ------------------------------------------------ 
  62     Call to deprecated method l() of class Drupal.  
  63     Call to deprecated method l() of class Drupal.  
  64     Call to deprecated method l() of class Drupal.  
  65     Call to deprecated method l() of class Drupal.  
 ------ ------------------------------------------------ 

 ------ --------------------------------------------------- 
  Line   src/Form/CategoryDeleteForm.php                    
 ------ --------------------------------------------------- 
  41     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/CategoryForm.php                          
 ------ --------------------------------------------------- 
  128    Call to deprecated function drupal_set_message().  
  134    Call to deprecated function drupal_set_message().  
  138    Call to deprecated method urlInfo() of class       
         Drupal\Core\Entity\EntityInterface.                
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Form/MassContactMessageConfirmForm.php         
 ------ --------------------------------------------------- 
  285    Call to deprecated function drupal_set_message().  
  292    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/AdminSettingsFormTest.php                               
 ------ ----------------------------------------------------------------------- 
  14     Class Drupal\mass_contact\Tests\Form\AdminSettingsFormTest extends     
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  27     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/EmailBodyFormTest.php                                   
 ------ ----------------------------------------------------------------------- 
  13     Class Drupal\mass_contact\Tests\Form\EmailBodyFormTest extends         
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  26     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
 ------ ----------------------------------------------------------------------- 

 ------ ----------------------------------------------------------------------- 
  Line   src/Tests/Form/EmailHeaderFormTest.php                                 
 ------ ----------------------------------------------------------------------- 
  14     Class Drupal\mass_contact\Tests\Form\EmailHeaderFormTest extends       
         deprecated class Drupal\system\Tests\System\SystemConfigFormTestBase.  
  27     Call to method setUp() of deprecated class                             
         Drupal\simpletest\WebTestBase.                                         
  33     Call to deprecated method strtolower() of class                        
         Drupal\Component\Utility\Unicode.                                      
 ------ ----------------------------------------------------------------------- 

 ------ ------------------------------------------------- 
  Line   tests/src/Functional/Form/CategoryFormTest.php   
 ------ ------------------------------------------------- 
  43     Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
  94     Call to deprecated method strtolower() of class  
         Drupal\Component\Utility\Unicode.                
 ------ ------------------------------------------------- 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/CategoryAccessControlHandlerTest.php                   
 ------ ------------------------------------------------------------------------ 
  16     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\CategoryAccessControlHandlerTest.      
 ------ ------------------------------------------------------------------------ 

 ------ --------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Functional\MassContactTestBase)  
 ------ --------------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                            
         Drupal\Component\Utility\Unicode.                                                                                          
 ------ --------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\CategoryAccessControlHandlerTest)  
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 
  21     Call to deprecated method strtolower() of class                                                                                     
         Drupal\Component\Utility\Unicode.                                                                                                   
 ------ ------------------------------------------------------------------------------------------------------------------------------------ 

 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\Entity\MassContactCategoryTest)  
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                                   
         Drupal\Component\Utility\Unicode.                                                                                                 
 ------ ---------------------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\MassContactTest)  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                    
         Drupal\Component\Utility\Unicode.                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ -------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\OptOutTest)  
 ------ -------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                               
         Drupal\Component\Utility\Unicode.                                                                             
 ------ -------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------------------------------------------------- 
  Line   tests/src/Kernel/CategoryCreationTrait.php (in context of class Drupal\Tests\mass_contact\Kernel\PermissionsTest)  
 ------ ------------------------------------------------------------------------------------------------------------------- 
  21     Call to deprecated method strtolower() of class                                                                    
         Drupal\Component\Utility\Unicode.                                                                                  
 ------ ------------------------------------------------------------------------------------------------------------------- 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/Entity/MassContactCategoryTest.php                     
 ------ ------------------------------------------------------------------------ 
  20     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\Entity\MassContactCategoryTest.        
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/MassContactTest.php                                    
 ------ ------------------------------------------------------------------------ 
  18     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\MassContactTest.                       
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------ 
  Line   tests/src/Kernel/OptOutTest.php                                         
 ------ ------------------------------------------------------------------------ 
  18     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class  
         Drupal\Tests\mass_contact\Kernel\OptOutTest.                            
 ------ ------------------------------------------------------------------------ 

 ------ ------------------------------------------------------------------------- 
  Line   tests/src/Kernel/Plugin/MassContact/GroupingMethod/RoleTest.php          
 ------ ------------------------------------------------------------------------- 
  19     Usage of deprecated trait Drupal\simpletest\UserCreationTrait in class   
         Drupal\Tests\mass_contact\Kernel\Plugin\MassContact\GroupingMethod\Role  
         Test.                                                                    
 ------ ------------------------------------------------------------------------- 

                                                                                
 [ERROR] Found 31 errors
CommentFileSizeAuthor
#7 interdiff-3051118-4-7.txt1004 bytes-enzo-
#7 drupal_9_deprecated_code-3051118-7.patch19.4 KB-enzo-
#4 drupal_9_deprecated_code-3051118-4.patch18.29 KBSergiu Stici
#2 drupal_9_deprecated_code-3051118-2.patch11.45 KBSergiu Stici
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

waverate created an issue. See original summary.

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Active » Needs review
FileSize
drupal_9_deprecated_code-3051118-2.patch11.45 KB

Here is the patch, please review.

Status: Needs review » Needs work

The last submitted patch, 2: drupal_9_deprecated_code-3051118-2.patch, failed testing. View results

Sergiu Stici’s picture

Sergiu Stici CreditAttribution: Sergiu Stici at FFW commented
Status: Needs work » Needs review
FileSize
drupal_9_deprecated_code-3051118-4.patch18.29 KB

Status: Needs review » Needs work

The last submitted patch, 4: drupal_9_deprecated_code-3051118-4.patch, failed testing. View results

waverate’s picture

waverate CreditAttribution: waverate commented

drupal-check against mass_contact-8.x-1.x-dev (4 Feb 2019) with patch at #4 applied.

Still has a few errors:


 ------ -------------------------------------------- 
  Line   src/Tests/Form/AdminSettingsFormTest.php    
 ------ -------------------------------------------- 
  27     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

 ------ -------------------------------------------- 
  Line   src/Tests/Form/EmailBodyFormTest.php        
 ------ -------------------------------------------- 
  26     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

 ------ -------------------------------------------- 
  Line   src/Tests/Form/EmailHeaderFormTest.php      
 ------ -------------------------------------------- 
  26     Call to method setUp() of deprecated class  
         Drupal\simpletest\WebTestBase.              
 ------ -------------------------------------------- 

                                                                                
 [ERROR] Found 3 errors
-enzo-’s picture

-enzo- CreditAttribution: -enzo- at weKnow Inc commented
FileSize
drupal_9_deprecated_code-3051118-7.patch19.4 KB
interdiff-3051118-4-7.txt1004 bytes

Hi @waverate

After the test, the patch with a current branch only was error remains, I did a fix for that and all looks ok now.

-enzo-’s picture

-enzo- CreditAttribution: -enzo- at weKnow Inc commented
Status: Needs work » Needs review
gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at Axelerant for Drupal India Association commented
Status: Needs review » Closed (duplicate)