drupal-check against contextual_range_filter-8.x-1.x-dev (29 Jan 2018)


 ------ --------------------------------------------------- 
  Line   src/Form/ContextualRangeFilterAssignmentForm.php   
 ------ --------------------------------------------------- 
  180    Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

                                                                                
 [ERROR] Found 1 error
CommentFileSizeAuthor
#4 changed_deprecated_drupal_set_message-3051095-4.patch854 bytesoleksandr.s
#2 d9_depreciation-3051095-2.patch856 byteswaverate

Comments

waverate created an issue. See original summary.

waverate’s picture

waverate commented
Status: Active » Needs review
StatusFileSize
new d9_depreciation-3051095-2.patch856 bytes

Patch attached.

Status: Needs review » Needs work

The last submitted patch, 2: d9_depreciation-3051095-2.patch, failed testing. View results

oleksandr.s’s picture

oleksandr.s commented
StatusFileSize
new changed_deprecated_drupal_set_message-3051095-4.patch854 bytes

Replaced messenger service object initiation by using already initiated messenger service in parent classes.

oleksandr.s’s picture

oleksandr.s commented
Status: Needs work » Needs review
oleksandr.s’s picture

oleksandr.s commented
Issue tags: +RockSolidCodeSprint
kelt88’s picture

kelt88 commented
Status: Needs review » Reviewed & tested by the community

Reviewed and tested patch #4 locally. Works fine. Thanks.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: changed_deprecated_drupal_set_message-3051095-4.patch, failed testing. View results

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Needs work » Reviewed & tested by the community

+1 RTBC

  • Beakerboy committed c10fc56 on 8.x-1.x 
    Issue #3051095 by waverate, aleksandr.s: Drupal 9 Deprecated Code Report
beakerboy’s picture

beakerboy
Primary language English
Location Kentucky
commented
Assigned: Unassigned » beakerboy
Status: Reviewed & tested by the community » Fixed

Merged into dev. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.