Looking at https://tastybackend.com/articles

It seems like there is a link there which really just shouldn't exist:

<div class="site-name visually-hidden">
      <a href="/" title="Home" rel="home">Tasty Backend</a>
    </div>

This is a bit confusing to keyboard only users and not really useful for anyone as it is redundant. The problem is in #6 which has focus, but has no reason to be there.

Found via https://accessibilityinsights.io/

CommentFileSizeAuthor
#3 remove-hidden-link-3050577-3.patch1007 bytesfconnolly
Screen Shot 2019-04-24 at 3.49.04 PM.png92.22 KBmgifford

Comments

mgifford created an issue. See original summary.

mgifford’s picture

mgifford
he/him
Primary language English
commented
Issue summary: View changes
fconnolly’s picture

fconnolly commented
StatusFileSize
new remove-hidden-link-3050577-3.patch1007 bytes

Should be fixed. I'm not super familiar with twig or umami, so this could have had unintended consequences, but I checked it in my browser and ran the automated tests and it was ok.

fconnolly’s picture

fconnolly commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

I think this looks good, it is a small fix and it improves a11y. +1.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Title: Remove hidden ""Tasty Backend" link in menu » Remove hidden site name link in menu

Clarifying that the title is not always "Tasty Backend" the title. It's whatever the user has set the site name to.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Tested locally - works as advertised.

Committed and pushed 15d1f9e782 to 8.8.x and eb37d16c47 to 8.7.x. Thanks!

diff --git a/core/lib/Drupal/Core/Entity/EntityForm.php b/core/lib/Drupal/Core/Entity/EntityForm.php
index b90d1d209d..16a72bc33a 100644
--- a/core/lib/Drupal/Core/Entity/EntityForm.php
+++ b/core/lib/Drupal/Core/Entity/EntityForm.php
@@ -2,6 +2,7 @@
 
 namespace Drupal\Core\Entity;
 
+use Drupal\Core\Entity\Exception\UndefinedLinkTemplateException;
 use Drupal\Core\Form\FormBase;
 use Drupal\Core\Extension\ModuleHandlerInterface;
 use Drupal\Core\Form\FormStateInterface;

This part has nothing to do with the fix. Removed from commit.

  • alexpott committed 15d1f9e on 8.8.x 
    Issue #3050577 by fconnolly, mgifford: Remove hidden site name link in...

  • alexpott committed eb37d16 on 8.7.x 
    Issue #3050577 by fconnolly, mgifford: Remove hidden site name link in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.