API page: https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Template%...

https://twig.symfony.com/doc/2.x/extensions/i18n.html is a 404.

CommentFileSizeAuthor
#7 @see_link_in_TwigNodeTrans_docs_is_a-404_3050448-7.patch1.21 KBkkalaskar
#4 @see_link_in_TwigNodeTrans_docs_is_a-404_3050448-4.patch603 byteskkalaskar

Comments

joachim created an issue. See original summary.

idebr’s picture

idebr commented

https://twig-extensions.readthedocs.io/en/latest/i18n.html might be a suitable replacement.

cilefen’s picture

cilefen commented
Issue tags: +Novice
kkalaskar’s picture

kkalaskar commented
StatusFileSize
new @see_link_in_TwigNodeTrans_docs_is_a-404_3050448-4.patch603 bytes

Hi @joachim

I created a patch with a suggestion of @idebr. Please review once.

Also, I found following links of the drupal website. Where we need to update the old link.

  1. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Template%...
  2. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Template%...
  3. https://api.drupal.org/api/drupal/core%21lib%21Drupal%21Core%21Template%...
kkalaskar’s picture

kkalaskar commented
Status: Active » Needs review
idebr’s picture

idebr commented
Status: Needs review » Needs work

Change looks good! However, there is another occurrence of the same URL in \Drupal\Core\Template\TwigTransTokenParser. This URL should be replaced as well.

kkalaskar’s picture

kkalaskar commented
StatusFileSize
new @see_link_in_TwigNodeTrans_docs_is_a-404_3050448-7.patch1.21 KB

@idebr
I added @see into \Drupal\Core\Template\TwigTransTokenParser.

kkalaskar’s picture

kkalaskar commented
Status: Needs work » Needs review
joachim’s picture

joachim commented
Status: Needs review » Reviewed & tested by the community

Thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Can we get a follow-up to fix all the other twig.sensiolabs.org links - these are not broken but they are redirects so could break at any time.

Committed and pushed 85029e08f6 to 8.8.x and dce1537959 to 8.7.x. Thanks!

Credited @joachim for opening the issue and @idebr for issue review.

  • alexpott committed 85029e0 on 8.8.x 
    Issue #3050448 by kkalaskar, joachim, idebr: @see link in TwigNodeTrans...

  • alexpott committed dce1537 on 8.7.x 
    Issue #3050448 by kkalaskar, joachim, idebr: @see link in TwigNodeTrans...
idebr’s picture

idebr commented
Related issues: +#3053129: Links to twig.sensiolabs.org are redirects: replace with its destination URLs 1.x version

Filed follow-up #3053129: Links to twig.sensiolabs.org are redirects: replace with its destination URLs 1.x version

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.