Problem/Motivation

In #3050448: @see link in TwigNodeTrans docs is a 404 a link to twig.sensiolabs.org was replaced because it returned a 404. All URLs to twig.sensiolabs.org are currently redirects so so they could break at any time.

Proposed resolution

Replace links to twig.sensiolabs.org with its destination URL.

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

Links to twig.sensiolabs.org are replaced with its destination URL.

API changes

None.

Data model changes

None.

CommentFileSizeAuthor
#5 replace_with_destination_URLs-3053129-5.patch6.16 KBr.shaikh
#2 replace_with_destination_URLs-3053129-2.patch6.16 KBr.shaikh

Comments

idebr created an issue. See original summary.

r.shaikh’s picture

r.shaikh commented
StatusFileSize
new replace_with_destination_URLs-3053129-2.patch6.16 KB

@Ide Braakman (idebr).... I have made changes as you suggested and created patch.
Kindly review.

r.shaikh’s picture

r.shaikh commented
Status: Active » Needs review
idebr’s picture

idebr commented
Title: Links to twig.sensiolabs.org are redirects: replace with its destination URLs » Links to twig.sensiolabs.org are redirects: replace with its destination URLs 1.x version
Status: Needs review » Needs work

Drupal is using Twig 1.x, so we need to use the 1.x version of the documentation. For example:
2.x: https://twig.symfony.com/doc/2.x/templates.html
1.x: https://twig.symfony.com/doc/1.x/templates.html

r.shaikh’s picture

r.shaikh commented
StatusFileSize
new replace_with_destination_URLs-3053129-5.patch6.16 KB

@Ide Braakman (idebr).... I have made changes as you suggested.
Kindly review.

r.shaikh’s picture

r.shaikh commented
Status: Needs work » Needs review
idebr’s picture

idebr commented
Status: Needs review » Reviewed & tested by the community

Thanks! The patch applies correctly and updates the links to the relevant documentation page.

  • lauriii committed c68e087 on 8.8.x 
    Issue #3053129 by R.shaikh, idebr: Links to twig.sensiolabs.org are...
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Version: 8.8.x-dev » 8.7.x-dev
Status: Reviewed & tested by the community » Fixed

Committed c68e087 and pushed to 8.8.x. Since this touches only documentation, I also backported this to 8.7.x. Thanks!

  • lauriii committed 1c8a838 on 8.7.x 
    Issue #3053129 by R.shaikh, idebr: Links to twig.sensiolabs.org are...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.