The function ctools_modal_add_plugin_js() contains calls to file(exists(...)). From the context it can be seen that this was supposed to read file_exists(...).

Source: https://git.drupalcode.org/project/ctools/blob/7712ed7d1/includes/modal....

The function is marked as deprecated, but still used by the following functions:

  • ctools_context_handler_edit_criteria()
  • ctools_context_admin_includes()
CommentFileSizeAuthor
#3 3048896-3.patch1017 bytesjoelpittet

Comments

ciss created an issue. See original summary.

ciss’s picture

ciss commented
Issue summary: View changes
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Active » Needs review
StatusFileSize
new 3048896-3.patch1017 bytes

Thanks for the report @ciss, that looks wrong.

  • joelpittet committed 7cc3586 on 7.x-1.x 
    Issue #3048896 by joelpittet, ciss: Invalid function calls in...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I've committed this to the dev release for the next release.

ciss’s picture

ciss commented

Thanks! Btw, I discovered these while running phan with the PHP7 compatibility config.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Is there documentation around that setup someplace? I was playing with PHPStan at drupalcon for @deprecated
https://github.com/mglaman/drupal-check/wiki/Drupal-9-Readiness

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

chris matthews’s picture

chris matthews commented
Parent issue: » #3031732: Plan for CTools 7.x-1.16 release