The SMTP module has an option whereby it can be installed and enabled, but "inactive". In this case Webform should not use it to send HTML emails, otherwise emails will be badly formatted.

CommentFileSizeAuthor
#4 3048252-4.patch7.29 KBjrockowitz
#2 3048252-2.patch4.24 KBjrockowitz

Comments

alberto56 created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3048252-2.patch4.24 KB

The attached should now account for the SMTP module being turned on/off.

I would like to add some additional API test coverage before committing this patch.

alberto56’s picture

alberto56 commented

I'll leave at needs review because you want to add test coverage, however the version in comment 2 works in my tests. Thanks!

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3048252-4.patch7.29 KB

The attached patch now includes test coverage.

Status: Needs review » Needs work

The last submitted patch, 4: 3048252-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed

  • jrockowitz committed b2d14cf on 8.x-5.x 
    Issue #3048252 by jrockowitz: Check whether SMTP module is active in...
jrockowitz’s picture

jrockowitz commented
Status: Needs work » Fixed
alberto56’s picture

alberto56 commented

@jrockowitz thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.