Update the stable version of drupal/coder to ˆ8.3.2

Here's the path to core/composer.json

Try again, this time with a/ b/

The problem in the console log is

Your requirements could not be resolved to an installable set of packages.
Problem 1
- The requested package drupal/coder (locked at 8.3.1, required as ^8.3.2) is satisfiable by drupal/coder[8.3.1] but these conflict with your requirements or minimum-stability.

I did not update the composer.lock file - is that also required in the patch?

Thanks for the composer.lock update @kim.pepper. So now we get

Package operations: 0 installs, 2 updates, 0 removals
  - Updating squizlabs/php_codesniffer (3.4.1 => 3.4.2)
  - Updating drupal/coder (8.3.1 => 8.3.2):  Checking out 44c80c2107

which is good. The tests all pass.

The new sniffs do not automatically get run, they need to be added to core/phpcs.xml.dist, so here is that change added, and I will expect lots of coding standards failures now. I have only added the two new sniffs I wrote Drupal.Commenting.Deprecated and Drupal.Semanitcs.FunctionTriggerError. There may be other new sniffs, but they can be tested later.

[edit: I noticed a typo in my patch Commenting.DeprecatedSniff should be Commenting.Deprecated so that may cause a failure, or at minimum that sniff will not be run]

Cancelled the test in #7 as I noticed

Executing PHPCS.
ERROR: Referenced sniff "Drupal.Commenting.DeprecatedSniff" does not exist

Here is the corrected patch.

Fixing typo. Sorry for the noise. I can't run this locally at the moment, so my errors are not spotted until running on d.o.

Thanks alexpott

Core should always pass its coder configuration.

Yes I knew that. But now I see what you mean, create separate issues to test each new sniff and fix it. I was just trying to see what failures we had here.

1744 standards violations is a nice nig number to work on :-)

I have raised:
#3048495: Fix Drupal.Semantics.FunctionTriggerError coding standard
#3048498: [≈Nov. 11] Fix Drupal.Commenting.Deprecated coding standard

But I suppose that work should wait until this issue is committed.

Thanks @alexpott for the commit. Yes, now we can work on the actual core fixes.

ha. I did not mean to change that status. Must have been a stale form that I posted to, without doing a refresh (which seems odd because I reloaded the page to see your commit). Anyway, thanks for resetting to fixed.

Fixed typo in issue summary and removed remaining tasks which are now covered in other issues.