For enhancers like the Date Time these require the DateTime module to be installed. The proposed solution for this is that we allow for enhancer to include a list of dependencies before it can be usable.

CommentFileSizeAuthor
#4 3047728--interdiff--2-4.txt0 bytese0ipso
#4 3047728--enhancer-dependencies.patch3.13 KBe0ipso
#3 datetime-enabled.png120.58 KBcindytwilliams
#3 datetime-disabled.png104.61 KBcindytwilliams
#2 3047728-jsonapi_extras-allow_dependencies_for_plugins-2.patch3.15 KBsean_e_dietrich
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sean_e_dietrich created an issue. See original summary.

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
CreditAttribution: sean_e_dietrich at Kanopi Studios commented
Status: Active » Needs review
FileSize
3047728-jsonapi_extras-allow_dependencies_for_plugins-2.patch3.15 KB

Included patch that allows for a dependency to be included in order to show in the list of field enhancers.

A way to test this is:

* Enable the jsonapi_extras module
* Confirm that the datetime module is not installed
* Go to admin/config/services/jsonapi/add/resource_types/
* Click overwrite on a node content type
* Select Advanced next to a date field
* Confirm that Date Time field enhancers are not in the list
* Enable the datetime module
* Go to admin/config/services/jsonapi/add/resource_types/
* Click overwrite on a node content type
* Select Advanced next to a date field
* Confirm that Date Time field enhancers are now in the list.

cindytwilliams’s picture

cindytwilliams CreditAttribution: cindytwilliams at Kanopi Studios commented
Status: Needs review » Reviewed & tested by the community
FileSize
datetime-disabled.png104.61 KB
datetime-enabled.png120.58 KB

I tested this patch, and it works as described.

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
CreditAttribution: e0ipso as a volunteer and at Lullabot commented
Status: Reviewed & tested by the community » Needs review
FileSize
3047728--enhancer-dependencies.patch3.13 KB
3047728--interdiff--2-4.txt0 bytes

bbrala’s picture

bbrala
Location Netherlands
CreditAttribution: bbrala at SWIS commented
Status: Needs review » Fixed

Seems this has been fixed and committed a while ago :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.