Closed (fixed)
Project:
Taxonomy Manager
Version:
2.0.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
9 Apr 2019 at 07:28 UTC
Updated:
7 Mar 2025 at 10:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jigish.addweb commented@kyuubi, Please review https://www.drupal.org/project/taxonomy_manager/issues/1120178 for the same, hope this will helps you.
thanks
Comment #3
kyuubi commentedHi @jigish.addweb,
That patch seems to be for D6?
Comment #4
pdenooijer commentedI see this behaviour as well, those fields post to the TaxonomyManagerForm instead of their own form. I think the solution could be that the TaxonomyManagerForm has to proxy it to the right form or the AJAX post has to be done to the right form.
Comment #5
ashutoshsngh commentedAny update on this issue?
We are also using this module and not able to update/create the referenced Media Entities.
Comment #6
kyuubi commentedHi guys,
This is not a long term solution but the fact is this current issue makes the module unusable.
I don't have the know how on Drupal's AJAX internals so I am overriding the JS in this patch to, instead of loading the term form via AJAX to redirect to the term edit screen.
Hopefully it helps someone.
Comment #7
ivnishComment #8
bunty badgujar commentedThanks @kyuubi for work around.
As currently term page is open in current tab. So after save or clicking back button tree structure removed because of page load. So, I am re-rolling your patch with small update to open term page in new tab.
Comment #9
vladimirausCan you verify it is still an issue in 2.0 branch?
Comment #10
carolpettirossi commented@VladimirAus,
I tested and the issue doesn't happen on the 2.0 version.
However, when using it along with term_reference_fancytree module, the fancytree doesn't work as expected with multi level taxonomy terms. I assume this is not a taxonomy manager issue, right?
Probably need to debug the term_reference_fancytree code to find out why the bug happens.
Comment #11
vladimirausGood idea to create separate bug for
term_reference_fancytreeComment #12
alfattal commentedI'm reopening this bug ticket as I'm getting exactly the same issue on version 2.0.8
Comment #13
vladimiraus@alfattal if you are reopening the bug, could you please provide
Comment #14
alfattal commented@VladimirAus Sorry for the late response. Here is the requested information:
Version of my environment:
Drupal 9.5.2
PHP 8.0.27
Taxonomy Manager version 2.0.7 and 2.0.8
Steps to reproduce:
Screenshots:
Here is the AJAX error on Chrome console:
Full trace:
Comment #15
alfattal commentedComment #16
alfattal commentedComment #17
alfattal commentedComment #18
alfattal commented@VladimirAus Did you have the chance to look into the information I provided?
Comment #19
delacosta456 commentedhi all
i also confirm this issue after selecting "Entity browser" as Widget on field's form display and now going back to the edit/add term page
Comment #20
vladimirausPlease create MR.
Comment #21
luisj0_c commentedI also have the same scenario as @delacosta456 and have confirmed that it is happening.
Comment #22
dburiak commentedIt looks like it's related to the Drupal core issue https://www.drupal.org/project/drupal/issues/2504115.
The workaround is to render the form without Ajax and send a taxonomy term ID through the URL query parameter.
The patch is attached.
I couldn't expand the tree to the given TID using the 'terms_to_expand' setting. Probably, maintainers could help with it.
Comment #23
vladimirausThank you for your contribution.
Can you create MR?
Comment #26
kolesnikoff commented@dburiak, I pushed your patch to the branch. Please fix the issues we found while testing the latest changes.
Comment #27
dburiak commentedThe PR is updated.
The updated patch can be found in the attachment.
Comment #28
dburiak commentedComment #29
phernand42 commentedI had to make a small adjustment to this patch since it did not apply cleanly due to another taxonomy manager patch that I had to apply earlier. Here is an updated patch just in case there are folks out that applied patch from issue 3474919.
Comment #31
jannakha commentedcreated a patch from MR (it's merged with #3474919)
make sure library/jquery.fancytree contains all JS - see #3467549
Comment #33
vladimirausThank you all! Committed! 🍻
This issue also fixes #3474919: Fix broken form element taxonomy manager tree.
Comment #34
torfjThis issues causes the toolbar position to be next to the tree and only abote the term page. Before it was above both the tree and term page. See images.
Before:

After:

Comment #35
torfjThe search functionality is also not working with these changes..
It also seems rather radical to completely render the form without Ajax, as this is not ideal from a user experience perspective. Do the maintainers have any plans to look into a solution where Ajax will still work on the form?
Comment #36
klausiOh my, this change destroyed one of the most important features of taxonomy manager: quickly clicking and navigating between terms. Created a citical bug report at #3505219: Restore term clicking AJAX functionality, will post a fix shortly for all AJAX fans.
Comment #37
vladimirausThis issue has been committed before. Keeping it closed.
Cheers @klausi for opening #3505219: Restore term clicking AJAX functionality. Please move all future commits there.
Comment #38
vladimirausOne of the reasons Ajax was removed is that it stopped working with media libraries and other Ajax dependent modules a while back.
Comment #39
klausiWe now have a new approach for the AJAX functionality in #3505219: Restore term clicking AJAX functionality that works with multi-value fields and media libraries.
Please test the merge request there. If there are no objections I'm planning to merge it in a couple of days.
Thanks @torfj for working on it so hard!