Problem/Motivation

use of the function t()

Proposed resolution

use method $this->t()

CommentFileSizeAuthor
#12 3046572-12.patch7.11 KBmanuel garcia
#12 interdiff-3046572-9-12.txt5.83 KBmanuel garcia
#9 3046572-9.patch6.69 KBmanuel garcia
#9 interdiff-3046572-8-9.txt893 bytesmanuel garcia
#8 3046572-8.patch5.82 KBmanuel garcia
#7 3046572-7.patch0 bytesmanuel garcia
#3 use-of-t-3046572.patch5.83 KBmaliknaik
#2 mailsystem-use_of_function_t-3046572-2-D8.patch510 bytesthalles

Comments

thalles created an issue. See original summary.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
StatusFileSize
new mailsystem-use_of_function_t-3046572-2-D8.patch510 bytes

Follow the patch!

maliknaik’s picture

maliknaik commented
StatusFileSize
new use-of-t-3046572.patch5.83 KB

Status: Needs review » Needs work

The last submitted patch, 3: use-of-t-3046572.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented

The #2 will be applied after: #3029285: Use short array syntax

thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
commented
Status: Needs work » Needs review
manuel garcia’s picture

manuel garcia commented
StatusFileSize
new 3046572-7.patch0 bytes

Rerroll

manuel garcia’s picture

manuel garcia commented
StatusFileSize
new 3046572-8.patch5.82 KB

Oops.

manuel garcia’s picture

manuel garcia commented
StatusFileSize
new interdiff-3046572-8-9.txt893 bytes
new 3046572-9.patch6.69 KB

Tackling the last offender.

The last submitted patch, 8: 3046572-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

Status: Needs review » Needs work

The last submitted patch, 9: 3046572-9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

manuel garcia’s picture

manuel garcia commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-3046572-9-12.txt5.83 KB
new 3046572-12.patch7.11 KB

Since we aren't testing the translation system, we should not be using t() at all in our tests.

manuel garcia’s picture

manuel garcia commented
Status: Needs review » Fixed

Thanks all!

  • Manuel Garcia committed 4517045 on 8.x-4.x 
    Issue #3046572 by Manuel Garcia, thalles, maliknaik: use of function t()
chris matthews’s picture

chris matthews commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.