Problem/Motivation
Per #2827160: @expectedException and @expectedException tags are replaced with best practice alternatives., we shouldn't use @expectedException or @expectedExceptionMessage in tests any more.
Proposed resolution
We should use something like this instead:
$this->setExpectedException(MailHandlerException::class, 'Unable to determine message recipient');
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | 3046172-18.patch | 10.56 KB | aleevas |
| #19 | interdiff-17-18.txt | 4.13 KB | aleevas |
| #19 | 3046172-18.patch | 10.56 KB | aleevas |
Comments
Comment #2
kavbiswa commentedComment #3
kavbiswa commentedPlease review the updated patch.
Comment #4
kavbiswa commentedComment #5
WidgetsBurritos commented@kavbiswa,
The patch doesn't seem to be applying. Please check your patch and try again. Thank you.
Comment #6
kavbiswa commentedComment #7
kavbiswa commentedPlease review the updated patch.
Comment #9
maliknaik commentedComment #10
maliknaik commentedComment #12
kavbiswa commentedComment #13
kavbiswa commentedComment #15
kavbiswa commentedComment #16
WidgetsBurritos commentedTests are failing so this still needs work
Comment #17
aleevasHere is my patch
Comment #19
aleevasThe next one
Comment #20
aleevasComment #21
WidgetsBurritos commented+1 RTBC
Comment #23
WidgetsBurritos commented