Closed (fixed)
Project:
Migrate Plus
Version:
8.x-4.x-dev
Component:
API
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
3 Apr 2019 at 02:13 UTC
Updated:
26 Apr 2019 at 14:29 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
quietone commentedThe event extracted from the patch in the other issue.
For the committer: The credit goes to all the people in the other issue (see IS).
Comment #3
heddnIs this really true? It would be if someone where using migrate tool's executable, but not generically speaking all executables.
Comment #4
marvil07 commentedIndeed, this only applies when the migrate executable with the required change to trigger the event is used.
It is a strange to point to a migrate_tools class from here, since that module depends on migrate_plus.
I would say it is better if we also declare the event there.
I am adding a new patch with the change here just in case, but we probably want to close this issue, and add the change here directly into #2809433: Migrate support for deleting items no longer in the incoming data.
Comment #5
heddnThis is basic event 101. Let's just remove the comment entirely? That solves the dilemma.
Comment #6
heddnFixing #5 on commit.
Comment #8
heddn