Problem/Motivation

Replace the deprecated assertEqual with assertEquals()

Proposed resolution

Replace assertEqual with assertEquals as per the drupal standards.

CommentFileSizeAuthor
#7 3045247-7.patch12.24 KBidebr
#5 deprecated-3045247-5.patch5.87 KBthalles
#2 deprecated-3045247.patch12.09 KBMithun S
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Mithun S created an issue. See original summary.

Mithun S’s picture

Mithun S
Primary language English
Location Bangalore
CreditAttribution: Mithun S at Specbee commented
Status: Active » Needs review
FileSize
deprecated-3045247.patch12.09 KB

Please review the patch applied.

Status: Needs review » Needs work

The last submitted patch, 2: deprecated-3045247.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

voleger’s picture

voleger
he/his
Primary language Ukrainian
Location Ukraine, Rivne
CreditAttribution: voleger as a volunteer and at GOLEMS GABB, Drupal Ukraine Community for Drupal Ukraine Community, GOLEMS GABB commented
Parent issue: » #3042568: Drupal 9 Deprecated Code Report for Token
thalles’s picture

thalles
Primary language Portuguese, Brazil
Location Teófilo Otoni - MG
CreditAttribution: thalles at CI&T commented
Status: Needs work » Needs review
FileSize
deprecated-3045247-5.patch5.87 KB

Apparently some assertEqual still should not be replaced

Status: Needs review » Needs work

The last submitted patch, 5: deprecated-3045247-5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

idebr’s picture

idebr CreditAttribution: idebr at ezCompany commented
Status: Needs work » Needs review
FileSize
3045247-7.patch12.24 KB

New patch after #3061605: Convert simpletest tests to phpunit/browser tests was committed.

  • Berdir committed 7613a7f on 8.x-1.x authored by idebr 
    Issue #3045247 by Mithun S, thalles, idebr: Replace deprecated...
Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir at MD Systems GmbH commented
Status: Needs review » Fixed

Thanks, looks good now that we actually have phpunit tests ;)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.