Problem/Motivation

The workspace toolbar tab button size is a bit weird on really small viewport width (below 16.5em, unoriented toolbar mode) and it's RTL styles are incomplete.

Proposed resolution

Float the item only if the toolbar is oriented.

User interface changes

Workspace toolbar tab will be similar to other tabs if viewport width is less than 16.5em.
RTL is fixed.

API changes

Nothing.

Data model changes

Nothing.

Remaining tasks

Consider using the same approach (media queries) as Contextual or Tour modules.
See the related issues.

CommentFileSizeAuthor
#2 workspaces-toolbar_item_fix-3045148-2.patch2.47 KBhuzooka
#2 workspace-toolbar-tab-button--after.png40.42 KBhuzooka
#2 workspace-toolbar-bar-button-rtl--after.png73.3 KBhuzooka
workspace-toolbar-tab-button--before.png49.59 KBhuzooka
workspace-toolbar-bar-button-rtl--before.png72.16 KBhuzooka

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new workspace-toolbar-bar-button-rtl--after.png73.3 KB
new workspace-toolbar-tab-button--after.png40.42 KB
new workspaces-toolbar_item_fix-3045148-2.patch2.47 KB
amateescu’s picture

amateescu commented
Priority: Minor » Normal
Status: Needs review » Reviewed & tested by the community

This is looking great, thanks for the patch! We had an old issue open about this (#2986366: Fix the Workspace mobile UI) but I just closed it since this one has a patch and screenshots :)

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 2: workspaces-toolbar_item_fix-3045148-2.patch, failed testing. View results

amateescu’s picture

amateescu commented
Status: Needs work » Reviewed & tested by the community

Random fail, queued a retest.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Yay, thanks. Fixed these on commit:

core/modules/workspaces/css/workspaces.toolbar.css
 20:3  ✖  Expected "color" to come before "background-color"      order/properties-order
 45:3  ✖  Expected "text-align" to come before "color"            order/properties-order

  • Gábor Hojtsy committed b69c30b on 8.8.x 
    Issue #3045148 by huzooka, amateescu: Workspaces toolbar tab sizing is...

  • Gábor Hojtsy committed 28ce151 on 8.8.x 
    Issue #3045148 by huzooka, amateescu: Followup to: workspaces toolbar...

  • Gábor Hojtsy committed 96cbf70 on 8.7.x 
    Issue #3045148 by huzooka, amateescu: Workspaces toolbar tab sizing is...
  • Gábor Hojtsy committed 9872ad9 on 8.7.x
    Issue #3045148 by huzooka, amateescu: Followup to: workspaces toolbar...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.