Problem/Motivation

The [webform_access:type:TYPE] tokens only include user email assigned to an access group which requires an account to be created for any email address that needs to be associated with an access group. There should be an easier way to add email accounts which are not associated with any user accounts to an access group

Proposed resolution

Allow access groups to have custom email addresses.

[webform_access:type:users] - Assigned user emails
[webform_access:type:admins] - Custom emails
[webform_access:type:all] - Assigned user emails and Custom emails

Remaining tasks

  • Add Emails to access group
  • Add update hook to update existing entities
  • Update APIs to support ::getEmails and ::setEmails()
  • Update webform_access.schema.yml
  • Add Emails to group listing
  • Write tests
  • Create a change record
  • Tag new beta release

User interface changes

Access group email addresses will be displayed on the group list and editable in the group edit form.

API changes

TBD

Data model changes

TBD

Release notes snippet

TBD

Comments

jrockowitz created an issue. See original summary.

jrockowitz’s picture

Issue summary: View changes
jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed 33a79aa on 3043755-access-group-email
    Issue #3043755: Allow access groups to have custom email addresses.
    
jrockowitz’s picture

Status: Active » Needs review
StatusFileSize
new61.72 KB

The attached patch includes the patch from #3043276: Allow selected users to administer webform access groups. Both these feature requests are tightly coupled and might require a single patch.

  • jrockowitz committed 6dff618 on 3043755-access-group-email
    Issue #3043755: Allow access groups to have custom email addresses. Add...
jrockowitz’s picture

StatusFileSize
new62.16 KB

Status: Needs review » Needs work

The last submitted patch, 7: 3043755-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

Status: Needs work » Needs review

  • jrockowitz committed 8ef8c78 on 3043755-access-group-email
    Issue #3043755: Allow access groups to have custom email addresses. Fix...

  • jrockowitz committed 952ccd1 on 3043755-access-group-email
    Issue #3043755: Allow access groups to have custom email addresses....
jrockowitz’s picture

StatusFileSize
new61.81 KB
jrockowitz’s picture

Issue summary: View changes

  • jrockowitz committed aaca7bf on 3043755-access-group-email
    Issue #3043755 by jrockowitz: Allow access groups to have custom email...
jrockowitz’s picture

StatusFileSize
new63.8 KB
brt’s picture

I've tested #15 and it seems to be working as expected.
Thank you very much.

jrockowitz’s picture

Status: Needs review » Reviewed & tested by the community

  • jrockowitz committed be8bcb9 on 8.x-5.x
    Issue #3043755 by jrockowitz: Allow access groups to have custom email...
jrockowitz’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.