Problem/Motivation

drupal-check results on commit hash:
source : [git] https://git.drupal.org/project/config_readonly f4cbb71b3ad9eb14c4ee5a23e89c93710458830c
source : http://cgit.drupalcode.org/config_readonly 


 ------ --------------------------------------------------- 
  Line   config_readonly.module                             
 ------ --------------------------------------------------- 
  19     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 

 [ERROR] Found 1 error

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#14 config_readonly-3042822-14.patch1.14 KBluca_loguercio
#10 3042822-10.patch1.17 KBpwolanin
#8 3042822-8.patch1.17 KBpwolanin
#5 interdiff-3042822-2-5.txt413 bytessuzymasri
#5 config_readonly-fixed_deprecated_code-3042822-5.patch1.16 KBsuzymasri
#4 Screen Shot 2019-04-15 at 11.22.17 PM.png11.79 KBsean_e_dietrich
#4 Screen Shot 2019-04-15 at 11.21.28 PM.png20.89 KBsean_e_dietrich
#3 config_readonly-fixed_deprecated_code-after-patch-3042822-3.patch.PNG6.26 KBAkanksha92
#2 config_readonly-fixed_deprecated_code-3042822-2.patch778 bytesi-trokhanenko

Comments

mcdwayne created an issue. See original summary.

i-trokhanenko’s picture

i-trokhanenko
Location Lutsk 🇺🇦
commented
Status: Active » Needs review
StatusFileSize
new config_readonly-fixed_deprecated_code-3042822-2.patch778 bytes

Please review!

Akanksha92’s picture

Akanksha92 commented
StatusFileSize
new config_readonly-fixed_deprecated_code-after-patch-3042822-3.patch.PNG6.26 KB

@i-trokhanenko the patch looks good. The patch applied to the module successfully. Please find the attached screenshot for the same. There were no more instances of the deprecated code for drupal_set_message

sean_e_dietrich’s picture

sean_e_dietrich
he/him
Primary language English
Location Sacramento, CA
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2019-04-15 at 11.21.28 PM.png20.89 KB
new Screen Shot 2019-04-15 at 11.22.17 PM.png11.79 KB

Before/After patch applied successfully but also solves the issue at hand. Marking RTBC.

Before

After

suzymasri’s picture

suzymasri
Location Greece
commented
StatusFileSize
new config_readonly-fixed_deprecated_code-3042822-5.patch1.16 KB
new interdiff-3042822-2-5.txt413 bytes

Updated drupal-check report:

 ------ --------------------------------------------------- 
  Line   config_readonly.module
 ------ --------------------------------------------------- 
  19     Call to deprecated function drupal_set_message():
         in drupal:8.5.0 and is removed from drupal:9.0.0.
         Use \Drupal\Core\Messenger\MessengerInterface::addMessage() instead.
 ------ --------------------------------------------------- 

 ------ --------------------------------------------------- 
  Line   src/Tests/ReadOnlyConfigTest.php
 ------ --------------------------------------------------- 
  18     Class Drupal\config_readonly\Tests\ReadOnlyConfigTest extends deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
  23     Call to method setUp() of deprecated class Drupal\simpletest\WebTestBase:
         in drupal:8.8.0 and is removed from drupal:9.0.0. Instead,
         use \Drupal\Tests\BrowserTestBase. See https://www.drupal.org/node/3030340.
 ------ --------------------------------------------------- 

 [ERROR] Found 3 errors

 ------ ---------------------------------------------------

Applying patch #2 fixes the drupal_set_message() error.
As for the deprecated WebTestBase errors, applying patch #10 on #2770755: Convert WebTestBase to BrowserTestBase fixes it.

To finalise this, core_version_requirement key needs to be added to the info file. Patch attached.

timmillwood’s picture

timmillwood
Primary language English
Location 🏴󠁧󠁢󠁷󠁬󠁳󠁿 Wales, UK
commented

LGTM considering the tests will be sorted in #2770755

pwolanin’s picture

pwolanin commented
Status: Reviewed & tested by the community » Needs work

for JWT I used:

core_version_requirement: ^8.7.12 || ^9.0

Better not to support before 8.7

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 3042822-8.patch1.17 KB

Will commit if tests pass.

Status: Needs review » Needs work

The last submitted patch, 8: 3042822-8.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

pwolanin’s picture

pwolanin commented
Status: Needs work » Needs review
StatusFileSize
new 3042822-10.patch1.17 KB

silly me

  • pwolanin committed 27301f9 on 8.x-1.x 
    Issue #3042822 by pwolanin, suzymasri, i-trokhanenko, sean_e_dietrich,...
pwolanin’s picture

pwolanin commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

luca_loguercio’s picture

luca_loguercio commented
StatusFileSize
new config_readonly-3042822-14.patch1.14 KB

For anyone wanting to apply patch to beta3

dave reid’s picture

dave reid
he/him
Primary language English
Location Nebraska USA
commented

Could we possibly get an new tagged release?

wheatpenny’s picture

wheatpenny commented

Agreed! Beta4 released.