Drupal 9 Deprecated Code Report

Simple enough fix. Here ya go

I am not sure why that failed to apply. I can pull down the dev branch and apply it without issues.

The patch looks good and applies cleanly.

Results after patch.

./vendor/bin/drupal-check modules/contrib/view_unpublished/
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

                                                                                             
 [OK] No errors                                                                              
                                                                                             

Marking as RTBC.

I believe that if you add drupal 9 as an option to the composer.json file in this project you can get a nice little Compatible with Drupal 9 badge in the Project information section on the module page.

Below is a code sample from a module that has the badge.

"require": {
        "php": "^7.1",
       "drupal/core": "^8 || ^9"
  },

It also looks like it may possible to get the badge by adding the 'core_version_requirement' key in the module's info.yml file, which, in turn, will add the version to the require section of composer.json. Example follows.

core_version_requirement: ^8 || ^9

Do you want to include this change in the patch here or open a separate issue?

@jenlampton,

I think this is a field that the maintainer of this module can fill in when editing the project. See https://www.drupal.org/project/slick/issues/3069793

I don't know about @JeroenT's suggestion, maybe that works, but I've seen lots of other projects doing what @jenlampton mentioned. Can the patch be updated to reflect that?

Apparently there is some maintainer text field that allows the maintainer to mark the module as D9 compatible to show the badge on the module's main page. I'm not a maintainer so I don't know where that switch is, unfortunately. But core maintainers have assured me that composer.yml and info.yml do not come into play.

Upgrade status module told me:

Add core_version_requirement: ^8 || ^9 to view_unpublished.info.yml to designate that the module is compatible with Drupal 9. See https://drupal.org/node/3070687.

It doesn't impact the d.o. "D9 badge" (which is indeed a text field on the d.o. project node edit form), but it looks like it's needed though.

Updated the patch provided in comment #3 to the correct use statement for the `ContentTypeCreationTrait` class as this fits with Drupal's Coding standards.

Didn't include `core_version_requirement` as patch won't apply because of `Information added by Drupal.org packaging script on 2017-01-04` in the info.yml file. I guess this is for the module maintainer to add.

Cheers

Actually attach the correct patch.....

@tresti88, your patch applied and resolve the deprecation warning. I don't follow your comment regarding core_version_requirement, and that should be included in the patch. So I created a new patch that includes that change. If it didn't apply for you, you might have been doing something wrong. 3042754-11.patch applies just fine for me on as fresh clone of the 8.x-1.x branch.

I should have mentioned that i was using composer to apply the patch to an existing project. I was conscious that this project hasn't had any dev commits since 2017. I didn't want to submit a patch that would fail to apply for those who just wanted to solve errors in the deprecated report. The core_version_requirement just threw up a warning. If you think it's best to add the core_version_requirement then i can update the patch to include the following in the info.yml file: core_version_requirement: ^8.4 || ^9

You don't need to update the patch, I've already done it because, yes, core_version_requirement should be included :)

The patch should be apply-able to dev so that the mods can merge it in cleanly. If it's conflicting with your project, then you must have applied other patches previously that this patch conflicts with. Patching prod repeatedly is not a good long term approach, for this reason (and others).

ahh gotya! Cheers :)

maintainers, should this be merged?

Can a maintainer please merge this?

I agree that would be helpful :)

Be aware that this module's functionality will be available in Drupal 9... Per-bundle unpublished content permissions. That will essentially deprecate this module for Drupal 9.

oh, I didn't know that @amaria, thanks for the info!

@amaria,

The change record you mention is still draft. The issue is still not resolved and that functionality won't be included before Drupal 9.1. So IMO this module is currently still valuable. Once that issue lands in core, we can provide an upgrade path to those permissions and deprecate this module.

i agree @JeroenT

this is a possible avenue to pursue: https://www.drupal.org/blog/the-maintainers-intiative

Fair enough, @JeroenT. Will merge after a quick review

any update @amaria?

Please re-roll against the latest dev. The patch did not apply.

re-rolling, see 3042754-12.patch

$ ./vendor/bin/drupal-check modules/view_unpublished/
 7/7 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%
                                                                                                          
 [OK] No errors

@amaria, thanks for commiting, should this issue be marked as fixed now? Also, can you flip the setting on this Drupal.org module page to enable the Drupal 9 support badge (example, d9support.png).