Drupal 9 Deprecated Code Report

I apply two small changes:

• Update .info.yml tags.
• Add drupalci.yml file.

I assigned the issue for reviewing...

Update the summary with latest drupal-check issues.

Remove the last commit hash from issue's summary.

I change the status to Needs work on new drupal-check -ad issues (updated summary).

Update the #2 patch.

$ drupal-check -ad web/modules/contact_block

 1/1 [============================] 100%

 [OK] No errors

Hide the previous #2 patch.

Update the patch to latest 8.x-1.x-dev branch.

Re-roll the patch #7.

Waiting for review from @Sutharsan.

Thanks for your contribution.

1. +++ b/src/Plugin/Block/ContactBlock.php
   @@ -58,6 +60,21 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
   +   * The currunt router match.
   

   Typo 'current'
   'route' not 'router'

2. +++ b/src/Plugin/Block/ContactBlock.php
   @@ -58,6 +60,21 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
   +   * @var \\Drupal\Core\Routing\CurrentRouteMatch
   

   One backslash too many.

3. +++ b/src/Plugin/Block/ContactBlock.php
   @@ -75,14 +92,20 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
   +   * @param ContactPageAccess $access_check_contact_personal
   +   *   Check the access of personal contact.
   

   The variable name is confusing, and is not consistent with description. Naming things is hard, but I choose to base it on the class name of the underlying service:
   $this->checkContactPageAccess, $check_contact_page_access, Check access to contact page, etc.

Hi @Sutharsan

I follow your recommendation and apply those changes in patch #10.

Please review and let me know if works.

BTW drupal-check said all is OK

+++ b/src/Plugin/Block/ContactBlock.php
@@ -75,14 +92,20 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
+   * @param ContactPageAccess $access_check_contact_personal
+   *   Check the access of personal contact.

Variable needs rename.
Use above property definition description.

Hi @Sutharsan

Thank you for the review, attached you can find the changes, please let me know if I miss something

Some more observations:

1. +++ b/src/Plugin/Block/ContactBlock.php
   @@ -58,6 +60,21 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
   +   * @var \Drupal\contact\Access\ContactPageAccess $accessCheckContactPersonal
   

   Do not append variable name to the type declaration.

2. +++ b/src/Plugin/Block/ContactBlock.php
   @@ -75,14 +92,20 @@ class ContactBlock extends BlockBase implements ContainerFactoryPluginInterface
   +   * @param ContactPageAccess $check_contact_page_access
   

   See above. Also, use fully qualified class name.

I tested the module with this patch, and found a but introduced by it. ContactBlock::defaultConfiguration is called when parent::__construct() is called and therefore before $this->configFactory is instantiated. Which causes an error in ContactBlock::defaultConfiguration. This patch delays parent::__construct() until all services are loaded.

I did not include the #15 comments.

I add my employer.

Verifying if #16 works and including feedback from #15.

Verified that #16 works fine and adding a patch that includes feedback from #15.

latest patch applied successfully ,Performed drupal-check and foud no issues

I've applied the patch contact_block_d9_deprecated_code_report-3042649-19.patch for 8.x-1.x-dev. It was checked using drupal check and worked successfully

"ContributionWeekend2020“ is the "official" tag suggested on global event page.

Thank you for the contribution!

The reviewed patch is committed! I closed the issue as Fixed!

@maintainer: Please remove my issue credit. I just fixed an issue tag which is a very simple minor contribution.

OK, Done!