Drupal 9 Deprecated Code Report

Created #3054630: replace \Egulias\EmailValidator\EmailValidator with \Drupal\Component\Utility\EmailValidator which fixes the failing tests.

@Waldoswndrwrld Thanks

@ChaseOnTheWeb, Kindly review the attached patch & let me know your views for the same.

Thanks!..

The strtolower() errors have already been fixed as part of #3041687: Deprecated Unicode::* methods need to be replaced., so the the current patches are now obsolete.

But there are now more errors reported by drupal-check:

./vendor/bin/drupal-check modules/contrib/smtp/
 9/9 [▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓▓] 100%

 ------ --------------------------------------------------- 
  Line   smtp.install                                       
 ------ --------------------------------------------------- 
  32     Call to deprecated function drupal_set_message().  
  33     Call to deprecated function drupal_set_message().  
 ------ --------------------------------------------------- 


 [ERROR] Found 2 errors                                                                                                 

I've updated the summary, hidden the existing patches, and set the status back to needs work.

Adding patch please review !

Looks Good

@Diego_Mow Sorry to move this again in NW, i found one more deprecated code ,

------ -------------------------------------------------------------------------------------------------------------------
Line src/Plugin/Mail/SMTPMailSystem.php
------ -------------------------------------------------------------------------------------------------------------------
488 Call to deprecated constant FILE_EXISTS_REPLACE: Deprecated in drupal:8.7.0 and is removed from drupal:9.0.0. Use
\Drupal\Core\File\FileSystemInterface::EXISTS_REPLACE.

i have created a patch to fix this kindly review,

Good catch swatichouhan012.

I checked the patch and continue to look ok for me.

Patch needs re-roll

Generated new patch considering code from patches #13 and #15 and also some new CR items to guarantee everything.

@Diego

In changing smtp_install() wouldn't it be better to cache the return value of \Drupal::messenger() and call addMessage from that?

If you're going to change Smtp_send_queue queuer please lets have a meaningful docblock, especially which indicates why the function exists. For example: "Add the outgoing mail to the SMTP Mail Queue."

Ditto for _smtp_mailer_send()

Question, not bug: for D9 compatibility, should file_save_data be rendered using a Drupal service instead?

Fixed the cause of the test error: the tester had been changed to expect smtpConnect() but the string is still SmtpConnect() and that is correct.

Also fixed the point about smtp_install() I mentioned above.

Also fixed the text of that message, which was still stuck in D7 menu terminology.

Tested and worked fine here.

The .info.yml file is missing the new core_version_key, see https://www.drupal.org/node/3070687.

Added the core version key in the info.yml file. Here is the updated patch.

+++ b/src/Plugin/Mail/SMTPMailSystem.php
@@ -485,7 +486,7 @@ class SMTPMailSystem implements MailInterface, ContainerFactoryPluginInterface {
               }
 
               $attachment_new_filename = \Drupal::service('file_system')->tempnam('temporary://', 'smtp');
-              $file_path = file_save_data($attachment, $attachment_new_filename, FILE_EXISTS_REPLACE);
+              $file_path = file_save_data($attachment, $attachment_new_filename, FileSystemInterface::EXISTS_REPLACE);
               $real_path = \Drupal::service('file_system')->realpath($file_path->uri);
 

I think this constant requires 8.7, so we should use ^8.7.7 || ^9 and remove the core: 8.x key.

Updated patch please review!