Drupal 9 Deprecated Code Removal

I created the patch, please review.

Thank you very much @Sergiu Stici for starting this.

This will have to wait a bit until a new branch is opened. At the moment getting this in would mean to increase the minumum Drupal version required to 8.7, which I am not keen at the moment.

In the meatime, a review:

1. +++ b/src/Plugin/ImageToolkit/Operation/gd/TextToWrapper.php
   @@ -400,22 +400,22 @@ class TextToWrapper extends GDImageToolkitOperationBase {
   +          $fit = mb_strlen($line) ? $begin + Unicode::strlen($line) : $end;
   

   One conversion is left out.

2. +++ b/src/Plugin/image_effects/ImageSelector/Dropdown.php
   @@ -105,10 +117,10 @@ class Dropdown extends ImageEffectsPluginBase {
   diff --git a/src/Tests/Update/Update8201Test.php b/src/Tests/Update/Update8201Test.php
   
   diff --git a/src/Tests/Update/Update8201Test.php b/src/Tests/Update/Update8201Test.php
   index 57fbbac..9629de8 100644
   
   index 57fbbac..9629de8 100644
   --- a/src/Tests/Update/Update8201Test.php
   
   --- a/src/Tests/Update/Update8201Test.php
   +++ b/src/Tests/Update/Update8201Test.php
   
   +++ b/src/Tests/Update/Update8201Test.php
   +++ b/src/Tests/Update/Update8201Test.php
   @@ -2,7 +2,7 @@
   
   @@ -2,7 +2,7 @@
    
    namespace Drupal\image_effects\Tests\Update;
    
   -use Drupal\system\Tests\Update\UpdatePathTestBase;
   +use Drupal\FunctionalTests\Update\UpdatePathTestBase;
    
    /**
     * Tests the upgrade path for enabling file_mdm and its submodules.
   
   
   

   The location of the file needs to be moved accordingly.

3. +++ b/tests/src/Functional/SettingsFormTest.php
   @@ -91,10 +91,10 @@ class SettingsFormTest extends BrowserTestBase {
   -    $this->assertNotEqual([], \Drupal::service('module_installer')->validateUninstall(['jquery_colorpicker']));
   +    $this->assertNotEquals([], \Drupal::service('module_installer')->validateUninstall(['jquery_colorpicker']));
   

   Maybe we can use assertNotEmpty here.

Running test with this patch applied on TravisCI https://travis-ci.org/mondrake/image_effects/jobs/516245179 yields more deprecations still to be addressed.

Tagging for DrupalCon Seattle Friday sprint.

Now, if you change all the occurrences of

suppress-deprecations: true

to false in the drupalci.yml file, you will get deprecation testing for the parch.

Looks like in deprecation testing we also get dependency module's deprecated uses :(

Here increasing Imagemagick's module minimum version to 3.x

file_unmanaged_* deprecated methods replaced by FileSystemInterface methods

file unmanaged deprecations are 8.7+, deprecations must be tested against 8.6, not 8.8.

#20 yes, this is working ahead :)

Changing ConfigurablePluginInterface to ConfigurableInterface.

Added drupal/jquery_colorpicker to composer.json require-dev.

Removed leftover Unicode methods.

> #20 yes, this is working ahead :)

Sorry, I actually didn't realize that I wasn't commenting in my own project, gmail likes to merge notifications for issues with the same title into threads and then I thought this was token.module ;)

That said, note that by including 8.7 changes, you will not be able to commit this for another 6 month, including the changes that would be perfectly fine to commit now. And it is pretty likely that you'll receive duplicate issues/patches about it until then. IMHO its better to either ignore 8.7 or do separate patches.

Thanks @Berdir

note that by including 8.7 changes, you will not be able to commit this for another 6 month

Fine, I am not sure that we will need to have any release of this module in that timeframe anyway, based on current issue log.

So my suggestion is to just ... wait, and reroll this patch as thing move along. If there are critical issues leading to a new release in this timeframe, then we may consider to commit parts of this. Otherwise, the module does not really need to get the deprecated methods converted ATM. Also, additional complexity is that I made a lot of deprecations in the Imagemagick module 8.x-2.x that will pop up here, and I am considering to postpone its 3.0 release to 2020 - for the same reasons: 2.x works well along multiple Drupal releases.

Removed the long output list form the IS and added here as a file.

Also, additional complexity is that I made a lot of deprecations in the Imagemagick module 8.x-2.x that will pop up here, and I am considering to postpone its 3.0 release to 2020

@mondrake. Are you suggesting that 8.x-2.x will not be supported in D9? The 8.x-3.x branch will be the way to go?

@waverate

Are you suggesting that 8.x-2.x will not be supported in D9? The 8.x-3.x branch will be the way to go?

Of the Imagemagick module? Yes. Imagemagick 8.x-3.x branch is already on par with core deprecations up to D8.7, and also removes all of the deprecations of the IM 8.x-2.x branch.

@mondrake. Sorry my mistake. I misread and thought you were talking about image_effects-8.x-2.x not being supported in D9.

#30: we will likely need a new branch for Image Effects, too, that will work with D8.8, D8.9 and D9+.

If we go for that then we could still backport issues to Image Effects 8.x-2.x that could run on D8.7 and less.

If we start removing deprecated code from Image Effects 8.x-2.x NOW, then it becomes impossible to have new releases of 8.x-2.x that work on earlier D8 versions.

We have options and approx 6-8 months to take a decision ATM.

Rerolled and removed 1.x->2.x update path and test

Reroll.

More deprecations

Committed to 8.x-3.x. Thank you!