Problem

In #2992737: The bundle inside the like modal title is not translatable the bundle name was retrieved and lowercased to be able to translate the bundle name in the like message. However, in some languages such as German the bundle name is a noun that should start with an uppercase letter.

Solution

Remove the strtolower that was added in the PR for #2992737: The bundle inside the like modal title is not translatable: https://github.com/goalgorilla/open_social/pull/1234/files#diff-7a427f5a...

CommentFileSizeAuthor
#3 lowercase_bundle_fix-3042115.patch582 byteskavbiswa

Comments

Kingdutch created an issue. See original summary.

kavbiswa’s picture

kavbiswa commented
Assigned: Unassigned » kavbiswa
kavbiswa’s picture

kavbiswa commented
Status: Active » Needs review
StatusFileSize
new lowercase_bundle_fix-3042115.patch582 bytes

Please review the patch added.

kavbiswa’s picture

kavbiswa commented
Assigned: kavbiswa » Unassigned
jaapjan’s picture

jaapjan commented

Thanks for the patch, created PR to review here.

https://github.com/goalgorilla/open_social/pull/1271

Code is fine. Will merge when tests are passing.

jaapjan’s picture

jaapjan commented
Status: Needs review » Fixed

Fixed for 4.x and 5.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.