Make the bundle inside the like modal title translatable.

CommentFileSizeAuthor
#2 modal-title-bundle-2992737-2.patch721 bytesyasmeensalah

Comments

yasmeensalah created an issue. See original summary.

yasmeensalah’s picture

yasmeensalah commented
StatusFileSize
new modal-title-bundle-2992737-2.patch721 bytes
jaapjan’s picture

jaapjan commented
Status: Active » Needs review
jaapjan’s picture

jaapjan commented

https://github.com/goalgorilla/open_social/pull/1186

jaapjan’s picture

jaapjan commented
Status: Needs review » Needs work

Getting this warning in our code checks: Only string literals should be passed to t() where possible. See: https://travis-ci.org/goalgorilla/open_social/jobs/482468876

In other words, how should we solve this issue?

jaapjan’s picture

jaapjan commented

For which entity type did you notice this translation bug by the way? For posts and nodes as well?

jaapjan’s picture

jaapjan commented
Status: Needs work » Needs review

Created a new PR here which should solve the issue and still complies to coding standards.

https://github.com/goalgorilla/open_social/pull/1234

ronaldtebrake’s picture

ronaldtebrake commented
Status: Needs review » Fixed

Thanks for the work done in here :)! Will be in 4.6.

  • jaapjan committed d3cca0b on 8.x-4.x 
    Issue #2992737 by jaapjan: fix translation of the bundle in like modal.
  • ronaldtebrake authored f5e3ab6 on 8.x-4.x
    Merge pull request #1234 from goalgorilla/feature/2992737-fix-like-...
kingdutch’s picture

kingdutch
he/him
Primary language English
commented

I've created a follow-up issue because a change in this issue can cause problems in certain languages: #3042115: Lowercase bundle can be incorrect in some languages

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.