I can see this warning in my log after login with social network with hybridauth module, since I udpated my PHP to 7.3.
Warning: session_id(): Cannot change session id when session is active in drupal_session_regenerate() (line 534 of /var/www/html/imart/sites/all/modules/apdqc/apdqc.session.inc).

CommentFileSizeAuthor
#4 apdqc-fix_session_change-3041730-4.patch1.66 KBsgdev
#3 apdqc-3041730-3-fix_session_change.patch1.06 KBarithmetric
#2 apdqc-3041730-2-fix_session_change.patch1.04 KBarithmetric

Comments

heyyo created an issue. See original summary.

arithmetric’s picture

arithmetric commented
Title: PHP 7.3 session » PHP 7.3 cannot change session warning
Status: Active » Needs review
Issue tags: +PHP 7.3
StatusFileSize
new apdqc-3041730-2-fix_session_change.patch1.04 KB

I've also run into this after upgrading a site with the apdqc module to use PHP 7.3.

As mentioned in the issue description, this warning occurs in the apdqc.session.inc file, which is based on Drupal core's session.inc file. This PHP warning was also reported affecting the Drupal core code in the following issue:
https://www.drupal.org/node/3025335

I'm attaching a patch that implements the same change used for Drupal core with the latest apdqc code in the 7.x-1.x branch.

arithmetric’s picture

arithmetric commented
StatusFileSize
new apdqc-3041730-3-fix_session_change.patch1.06 KB

Uploading patch with updated format.

sgdev’s picture

sgdev commented
Related issues: +#3025335: session_id() cannot be changed after session is started
StatusFileSize
new apdqc-fix_session_change-3041730-4.patch1.66 KB

Patch #3 does not match what was ultimately committed to core. APDQC should work exactly the same as core does in this regard: https://www.drupal.org/project/drupal/issues/3025335#comment-13338907

Attached is an updated patch for review, thanks.

  • arithmetric authored 8288b39 on 7.x-1.x 
    Issue #3041730 by arithmetric, ron_s: PHP 7.3 cannot change session...
mikeytown2’s picture

mikeytown2 commented
Status: Needs review » Fixed

#4 has been committed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.