Problem/Motivation

Are there any plans to update the module to Shariff lib v3?

CommentFileSizeAuthor
#4 3039848-3.patch3.55 KBchr.fritsch

Comments

chr.fritsch created an issue. See original summary.

criz’s picture

criz
he/him
Location Vienna/Austria
commented

Hi, can you explain what is not working with v3? We use it with this library version on some pages.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

By downloading the lib with composer and asset-packagist "npm-asset/shariff": "^3" the css and js ends up in a dist folder. Then the shariff module can not find the assets.

How did you solve that?

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Active » Needs review
StatusFileSize
new 3039848-3.patch3.55 KB

This would work for me

criz’s picture

criz
he/him
Location Vienna/Austria
commented

We don't use npm-asset, but load the library in composer.json as repository.
However, your code makes sense in this case, thanks. Still need to test it for all library subfolder options.

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Title: Any plans to update to Shariff 3 » Support Shariff 3 over composer npm-asset
1an’s picture

1an commented
Assigned: Unassigned » 1an
1an’s picture

1an commented
Status: Needs review » Reviewed & tested by the community

  • criz committed 39137db on 8.x-1.x authored by chr.fritsch 
    Issue #3039848 by chr.fritsch: Support Shariff 3 over composer npm-asset
criz’s picture

criz
he/him
Location Vienna/Austria
commented
Status: Reviewed & tested by the community » Fixed
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Thanks for committing so fast😊
Could you please tag a new release now? 😬

criz’s picture

criz
he/him
Location Vienna/Austria
commented

Sure, will create a release today or tomorrow!

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented

Thanks, I am looking forward to it :)

criz’s picture

criz
he/him
Location Vienna/Austria
commented

Done: https://www.drupal.org/project/shariff/releases/8.x-1.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.