When setting up new environments, it's often useful to first install Drupal, and then configure Elasticsearch Helper. Currently, the installation from an existing codebase with existing configuration will fail if Elasticsearch is not available (or improperly configured for the current environment). The same thing happens if someone wants to uninstall a module that define an Elasticsearch Helper plugin, if the Elasticsearch server is not available the module can't be uninstalled.

The attached patch simply catches the NoNodesAvailableException in the the elasticsearch_helper_modules_installed and elasticsearch_helper_module_preuninstall hooks.

CommentFileSizeAuthor
#2 interdiff_1-2.txt1.45 KBhkirsman
#2 elasticsearch_helper-prevent-installation-fatal-errors-3038485-2.patch4.84 KBhkirsman
prevent-installation-fatal-errors.patch3.18 KBfloretan

Comments

floretan created an issue. See original summary.

hkirsman’s picture

hkirsman commented
StatusFileSize
new elasticsearch_helper-prevent-installation-fatal-errors-3038485-2.patch4.84 KB
new interdiff_1-2.txt1.45 KB

Added simple test for this. Needed node dependency to be added.

hkirsman’s picture

hkirsman commented

Wondering if the test function should be empty so we could use automated testing here https://www.drupal.org/node/2720203/qa I mean there's no ES in drupal.org testing environment but the test would work if we don't check for the "Connected to Elasticsearch" string.

tormi’s picture

tormi
Primary language Estonian
Location Tallinn
commented

tekla_node in namespace Drupal\Tests\tekla_node\Functional; should probably be changed to something more neutral.