Problem/Motivation

In order for Umami to showcase multilingual capabilities in English and Spanish, we need to have CSV files with content in Spanish.

This is done in parallel to #3029839: Multilingual functionality - enable English and Spanish as part of Umami installation
and will become visible when #3037111: Import multilingual content into Umami is completed.

Proposed resolution

Generate CSV files for tags and recipe_categories taxonomies that are marked as fixed in #3028769: [META] Showcase Drupal's Multilingual Capabilities by implementing Umami in a 2nd language (Spanish)

CommentFileSizeAuthor
#9 ootb-ml-spanish-taxonomies-csv-3038297-6.patch1.31 KBsmaz
#5 interdiff_2-5.txt1.56 KBshaal
#5 ootb-ml-spanish-taxonomies-csv-3038297-5.patch1.31 KBshaal
#2 ootb-ml-spanish-taxonomies-csv-3038297-2.patch1.24 KBshaal

Comments

shaal created an issue. See original summary.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Active » Needs review
StatusFileSize
new ootb-ml-spanish-taxonomies-csv-3038297-2.patch1.24 KB

This patch contains both tags and recipe_categories taxonomies.

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Issue summary: View changes

Status: Needs review » Needs work

The last submitted patch, 2: ootb-ml-spanish-taxonomies-csv-3038297-2.patch, failed testing. View results

shaal’s picture

shaal
he/him
Primary language English
Location Boca Raton, FL
commented
Status: Needs work » Needs review
StatusFileSize
new ootb-ml-spanish-taxonomies-csv-3038297-5.patch1.31 KB
new interdiff_2-5.txt1.56 KB

To support the latest upcoming changes in #3037111: Import multilingual content into Umami
This patch is relocating Taxonomy Spanish CSV files to
default_content/languages/es/taxonomy_term/

New structure:

core/profiles/demo_umami/modules/demo_umami_content/default_content/
├── images
└── languages
    ├── en
    │   ├── article_body
    │   ├── block_content
    │   ├── node
    │   ├── recipe_instructions
    │   └── taxonomy_term
    └── es
        ├── article_body
        ├── block_content
        ├── node
        ├── recipe_instructions
        └── taxonomy_term

Version: 8.7.x-dev » 8.8.x-dev

Drupal 8.7.0-alpha1 will be released the week of March 11, 2019, which means new developments and disruptive changes should now be targeted against the 8.8.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

smaz’s picture

smaz
Primary language English
Location England, UK
commented
Status: Needs review » Reviewed & tested by the community

Patch applies cleanly, Umami still installs ok, CSV file in the correct format. This looks fine to me!

smaz’s picture

smaz
Primary language English
Location England, UK
commented
Status: Reviewed & tested by the community » Needs review

Wrong issue... whoops!

smaz’s picture

smaz
Primary language English
Location England, UK
commented
StatusFileSize
new ootb-ml-spanish-taxonomies-csv-3038297-6.patch1.31 KB

In terms of applying ok & the CSV content/structure etc., this is fine & I would set to RTBC. But:

The patch file has the following:

+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/taxonomy_term/recipe_category.csv
+1,Acompañamiento
+4,Tentempié

+++ b/core/profiles/demo_umami/modules/demo_umami_content/default_content/languages/es/taxonomy_term/tags.csv
+3,Cocción
+18,Champiñones
+22,Repostería

When I apply the patch & generate a diff, the characters appear normally rather than encoded like that - I'm not sure which is correct, or if it matters?

See attached.

smaz’s picture

smaz
Primary language English
Location England, UK
commented
Status: Needs review » Reviewed & tested by the community

Ignore the above - the patches are identical. Must be something to do with drupal.org / my browser / whatever.

kjay credited Eli-T.

kjay credited Gábor Hojtsy.

kjay credited estoyausente.

kjay credited saesa.

kjay’s picture

kjay commented
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: CSV files for Umami's taxonomies in Spanish » Spanish translations of Umami demo categories
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Version: 8.8.x-dev » 8.7.x-dev

Thanks, committed to 8.8. Will merge to 8.7 once the lift is up.

  • Gábor Hojtsy committed 51b68fc on 8.8.x 
    Issue #3038297 by shaal, smaz, estoyausente, kjay, Eli-T, saesa: Spanish...

  • Gábor Hojtsy committed 3364dcc on 8.7.x 
    Issue #3038297 by shaal, smaz, estoyausente, kjay, Eli-T, saesa: Spanish...
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Reviewed & tested by the community » Fixed

Thanks all!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.