Split off from #2954077: Update Migration plugin to current migration system standards

Can take code from this patch https://www.drupal.org/files/issues/2018-10-16/simplenews-migrate85-2954...

CommentFileSizeAuthor
#7 simplenews.issue-migrate-3037694-interdiff-2-7.txt2.25 KBadamps
#7 simplenews.issue-migrate-3037694-7.patch2.38 KBadamps
#2 simplenews-issue-migrate-3037694-2-D7.patch3.14 KBjcnventura

Comments

AdamPS created an issue. See original summary.

jcnventura’s picture

jcnventura
Primary language English
commented
StatusFileSize
new simplenews-issue-migrate-3037694-2-D7.patch3.14 KB

Attaching the simplenews migration code from comment #7 of #2954077: Update Migration plugin to current migration system standards

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Active » Needs review
jcnventura’s picture

jcnventura
Primary language English
commented
adamps’s picture

adamps commented

I don't use migration at the moment nor do I know much about it, so I am not the right person to test/review this. I'm willing to commit it if someone else can confirm they have tested and reviewed.

jcnventura’s picture

jcnventura
Primary language English
commented
Issue tags: +migrate-d7-d8
adamps’s picture

adamps commented
Version: 8.x-1.x-dev » 8.x-2.x-dev
StatusFileSize
new simplenews.issue-migrate-3037694-7.patch2.38 KB
new simplenews.issue-migrate-3037694-interdiff-2-7.txt2.25 KB
adamps’s picture

adamps commented
Issue tags: +Plan to commit

OK I now tested this on a site and it looks good. I used a simplified version.

  • AdamPS committed 75e9e81 on 8.x-2.x 
    Issue #3037694 by AdamPS, jcnventura: Add migration for simplenews_issue...
adamps’s picture

adamps commented
Status: Needs review » Fixed
Issue tags: -Plan to commit
jcnventura’s picture

jcnventura
Primary language English
commented

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.