Moderated By: gaborhojtsy

Hello and welcome to this Drupal 9 readiness meeting!

This meeting:
➤ Is for core and contributed project developers as well as people who have integrations and services related to core. Site developers who want to stay in the know to keep up-to-date for the easiest Drupal 9 upgrade of their sites are also welcome.
➤ Usually happens every other Monday at 19:00 UTC.
➤ Is done over chat.
➤ Happens in threads, which you can follow to be notified of new replies even if you don’t comment in the thread. You may also join the meeting later and participate asynchronously!
➤ Has a public agenda anyone can add to: https://www.drupal.org/project/drupal/issues/3037346
➤*Transcript will be exported and posted* to the agenda issue. For anonymous comments, start with a :bust_in_silhouette: emoji. To take a comment or thread off the record, start with a :no_entry_sign: emoji.

0️ Who is here today? Comment in the thread below to introduce yourself and tell us what you are here for.

gaborhojtsy Me! Core committer, D9 coordinator
gaborhojtsy cc @mglaman @mixologic @catch @alexpott @berdir @andypost @jibran @mikelutz
nerdstein me, nerdstein, still lurking but prepping for drupalcon
mglaman Late but here! Tooling experimenter
mglaman Wow phone.
mikelutz Hola!
alexpott alexpott, core committer, here to see what’s up - busy with other things atm.
drumm Neil Drumm, Drupal Association engineer
gnuget me, David, I'm maintaining a few contrib modules and I'm interested on make them work on D9.
amateescu Andrei, just lurking around :slightly_smiling_face:
lendude Len, putting kids to bed and reading up later
ikit-claw Am lurking
Nick Wilde Nick, he/him, contrib maintainer and job relevant
catch Nat, he/him, joining very late.

1️ Deprecation formats, re https://www.drupal.org/project/coding_standards/issues/3024461

gaborhojtsy the news I have here is that both @effulgentsia and pfrennsen promised to take a look this week
gaborhojtsy fingers crossed :smile:
gaborhojtsy hope you all don’t have concerns with the suggested format at this point :smile:

2️ Deprecation testing using phpstan

mglaman Rad to see Drupal CI integration patch!
gaborhojtsy testbot integration patch is complete theoretically at https://www.drupal.org/project/drupalci_testbot/issues/3034806 :smile:
gaborhojtsy I think the ball is now rolling with @mixologic to test and roll it into live :smile:
gaborhojtsy discussion last week was that this would be on an on-demand basis, by patching drupalci.yml in core (for core) or for adding a drupalci.yml for contrib
gaborhojtsy (for now)
gaborhojtsy and then we would look at running on contrib and making results available on project pages possibly weekly
mglaman More people are testing the root package which isn't just deprecation testing. So maybe bugs and performance fixes coming as well
mixologic @gaborhojtsy hey, sorry, I had a family medical emergency, so it might take a sec for me to get to. I do have my laptop, and I'll definitive have downtime, but I dint know when.
mglaman @mixologic family first!
mglaman Drupal family second ;)
mixologic Lol
gaborhojtsy @mixologic oh, family first for sure!
gaborhojtsy @gnuget this will be a useful tool for you as per your intro :slightly_smiling_face:
mixologic Yeah, I did get a far as running it Myself locally, and it seemed like phpstan wasn't actually working on the pathauto test.
gaborhojtsy @mixologic hm, any errors?
gnuget @gaborhojtsy Thanks!
mixologic Yeah it all seemed like phpstan couldn't autoload any of pathauto classes

3️ Simpletests! Down to one! ONE! according to http://simpletest-countdown.org/

gaborhojtsy Drumroll moment :smile:
alexpott So close!
amateescu :drum_with_drumsticks:
gaborhojtsy https://www.drupal.org/project/drupal/issues/3028663 also picked up some activity thanks to that
gaborhojtsy feedback / reviews there welcome :slightly_smiling_face:
lendude :dancerbanana:
lendude If nothing moves this before thursday office hours, I wanted to see if we can push that last one then
gaborhojtsy :thumbsup: although this is probably one that needs serious experts, no? :smile:
gaborhojtsy @lendude I tried to find the issue, can you post it?
lendude Last test:
lendude https://www.drupal.org/node/2809503
lendude waiting on https://www.drupal.org/project/drupal/issues/2947517
alexpott I will look at 2947517 tomorrow

4️ Symfony 4/5 compatibility at https://www.drupal.org/project/drupal/issues/2976394

gaborhojtsy This has stalled a bit recent weeks.
gaborhojtsy https://www.drupal.org/project/drupal/issues/3029197 needs a review, maybe from @alexpott or @larowlan and hopefully commit from the other person :smile:
alexpott @drumm @mixologic is there anyway to search all contrib code using http://cgit.drupal.org|cgit.drupal.org? I looked but I couldn’t find anything
gaborhojtsy and then there are two issues postponed on https://www.drupal.org/project/drupal/issues/3031577 which @alexpott worked on previously but help would be needed, since he is/was swamped with other things recently
drumm There isn’t a supported way to search everything now. Some people have copies of everything, and there’s some scripts kicking around, but nothing formal afaik
mglaman @alexpott @gaborhojtsy crazy idea, but going to type it out
mglaman Right now I have that deprecation bot. It isn’t running a lot of contrib, but could. however all of the JUnit is stuck in Jenkins. What if I added more projects and piped it into something query-able?
mglaman Or is that not good enough because it isn’t deprecated
gaborhojtsy well, this is deprecated in Symfony 4
mglaman ah
gaborhojtsy given where this issue is at ATM I have little hope we can make Drupal 8.7 compatible with Symfony 4 optionally (if someone patches composer files only) if we need to do it by alpha
gaborhojtsy that means that if we cannot do the changes in patch releases (due to the nature of the changes), we will need to test optional Symfony 4 and 5 compatibility altogether in the December release (8.8) with the community / contribs, as that will be the alst one before 9.0
gaborhojtsy which IMHO is cutting it quite short, but @Mile23 called me out on being too super careful before :smile:
nerdstein i actually like the idea of Symfony 4/5 compatibility in a 8.x release in prep for 9.0
nerdstein this buys more time and lessens the drupal 9 "release"
gaborhojtsy yeah I was hoping we can get to optional Symfony 4 compatibility in 8.7 but that does not seem realistic anymore given all other priorities people have
gaborhojtsy at least optional Twig 2 support landed and works :smile:
nerdstein i see it as being quite important if it can be squeezed, what would it take to do it? is there an issue i missed?
nerdstein i ask because i'd like to see if hook42 can work on it
gaborhojtsy @nerdstein yeah https://www.drupal.org/project/drupal/issues/2976394 has like 7 or so subissues, that would need to be resolved, but 2 are “easy” if https://www.drupal.org/project/drupal/issues/3031577 is done
nerdstein ok cool
gaborhojtsy @nerdstein https://www.drupal.org/project/drupal/issues/2976394 is where we update to Symfony 4 (in the testing patch) and see what fails
gaborhojtsy and then open subissues for those as it makes sense and work on them :slightly_smiling_face:
nerdstein okie dokie
nerdstein thank you @gaborhojtsy
Mile23 Uh... I called someone out?
andypost btw SF5 gonna change session service again https://github.com/symfony/symfony/issues/10557
Probably there's already issue to track that
gaborhojtsy @Mile23 TBH I think it was in good faith :)
gaborhojtsy @andypost as soon as Symfony 4 deprecates their current way it will start failing tests

5️ All the deprecations, any ongoing things we should help review / point people to?

mglaman March 20th I’ll be assisting in contribution sprints. My focus is to have people working on these issues. So I’ll be more active in the next meeting to find specific things for people to tackle
gaborhojtsy there is lot of action now on drupal_static() removal (due to deprecation) in the queue for example
gaborhojtsy eg https://www.drupal.org/project/drupal/issues/3036962
gaborhojtsy @berdir anything you are focused on now that needs help?
berdir @gaborhojtsy nothing too specific. https://www.drupal.org/project/drupal/issues/2999721 is a fairly good issue for people, tons of things to work on. next steps on my entity manager issue are updating all forms, @martin is working on that atm
berdir not a lot of time currently, but we'll have our drupal mountain camp starting thursday, might have some time to work on things then, but likely limited too :slightly_smiling_face:
gaborhojtsy @mglaman see above issue for some sprintable things :smile:
mglaman @berdir +1 on that issue, put it in the MidCamp “things to go over” list
berdir @mglaman yeah, you can basically just pick a function, check if there's an issue for it yet, if not start one. many files have their own sub-meta issue.. file.inc for example has various ongoing issues.
berdir also a fun exercise is to just comment out include of those files and see where it dies :wink:
berdir e.g. commenting out bootstrap.inc currently dies on drupal_valid_test_ua()
andypost On my side mostly done with action module issue from d9 mindmap + few ones like https://www.drupal.org/project/drupal/issues/2974253
andypost btw After Alpha deprecations could be delayed by more disruptive changes in 8.8 branch

6️ Seattle contribution days/rooms will be all week. I’ll be there Monday 1pm onwards :slightly_smiling_face: who else is coming?

gaborhojtsy Please enter your name/days in http://bit.ly/contribute-at-drupalcon-seattle if at all possible, that helps us plan sprints :slightly_smiling_face:
gaborhojtsy and also helps us plan meetings with key stakeholders like you :slightly_smiling_face:
gaborhojtsy (and announce them publicly on time :D)
mglaman I’ll be stuck at the booth for most of the event. But if there’s anything that would be good for me to attend involving PhpStan / static analysis I can set up some time
gaborhojtsy @mglaman thanks! we don’t currently have a discussion lined up there but it largely depends on how all the tools progress in the meantime :slightly_smiling_face:
mikelutz I should be there about Monday Afternoon on as well, though might be pretty tired at that point

7️ Any pressing topics you wanted to discuss / we can help with?

nerdstein this may sound like a dumb question, but i know this is putting a big burden on many of you. how are you feeling? do you need more support?
gaborhojtsy YES! :slightly_smiling_face:
nerdstein :+1: let me ramp up my marketing skills
gaborhojtsy yay!
gaborhojtsy the more channels/formats spread D9 info the better :slightly_smiling_face:
nerdstein :+1:
gaborhojtsy I will hold an Acquia webinar with Dries on the 20th for example :slightly_smiling_face: but bringing the topic to podcasts, doing blog posts about things, tweeting, celebrating, all helps
gaborhojtsy and I don’t mean for anyone to amplify the webinar, no, but Drupal 9 in general
gaborhojtsy @mglaman’s phpstan posts have been great and @mikelutz wanted to work on a post series as well :slightly_smiling_face:
gaborhojtsy we need people to run deprecation analyses with phpstan and also their test suites on their code, act on them (contrib and custom)
gaborhojtsy we need people working on Symfony 4 and 5 compatibility in core
gaborhojtsy removal of deprecated code that core is using
gaborhojtsy making multilingual migrations stable :slightly_smiling_face:
mglaman I also have https://deprecationbot.glamanate.com/ running. I need to add more contrib to the jobs (generate via text in `check_paths) https://github.com/mglaman/deprecation_bot
gaborhojtsy the list is long but the above are the top ones AFAIS ^^^
mglaman stop-gap until DrupalCI is running
gaborhojtsy @mglaman hm, I wanted to check if you are running the updated ignore variant that makes it run with migrate, but https://deprecationbot.glamanate.com/job/core_migrate/lastBuild/testReport/ seems like there are other issues
gaborhojtsy @mglaman all problems there and on other reports are showing up as “PHPstan.null”
mglaman @gaborhojtsy yeah somthing seems wrong
mglaman it’s like it used an older junit format
mglaman which I should have it just use the checkstyle
gaborhojtsy it does say 25 fails which is better than before where the build failed with timeout
gaborhojtsy :smile: so you do run the latest version :smile:
mikelutz @mglaman I’m going to make you teach me all things phpstan at midcamp, lol.

8️ Thanks all for coming and for doing amazing work :slightly_smiling_face:

9️ See you in two weeks online :slightly_smiling_face:

Comments

Gábor Hojtsy created an issue. See original summary.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Issue summary: View changes
gnuget’s picture

gnuget
Primary language Spanish
commented

HI!

How can I access the chat? is via Slack?

justafish credited Berdir.

justafish credited Lendude.

justafish credited Mile23.

justafish credited Mixologic.

justafish credited amateescu.

justafish credited andypost.

justafish credited drumm.

justafish credited mglaman.

justafish credited mikelutz.

justafish credited nerdstein.

justafish credited xjm.

justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Issue summary: View changes
justafish’s picture

justafish
she/her
Primary language English
Location London, UK
commented
Status: Active » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Version: 9.x-dev » 9.0.x-dev

The 9.0.x branch will open for development soon, and the placeholder 9.x branch should no longer be used. Only issues that require a new major version should be filed against 9.0.x (for example, removing deprecated code or updating dependency major versions). New developments and disruptive changes that are allowed in a minor version should be filed against 8.9.x, and significant new features will be moved to 9.1.x at committer discretion. For more information see the Allowed changes during the Drupal 8 and 9 release cycles and the Drupal 9.0.0 release plan.