Problem/Motivation

I think that the media query used in toolbar.icons.theme.css should be the same as the toolbar.standard breakpoint.

Proposed resolution

Standardize the standard media query.

Remaining tasks

Decide which one we prefer, and provide a patch (toolbar module and stable theme).

User interface changes

Not too much, but definitely something...

API changes

Nothing.

Data model changes

Nothing.

Notes

My preference is to provide the active toolbar breakpoint from ToolBar to the HTML document (e.g. by classes) and use that info for theming the different toolbar layouts instead of repeating the media query statically:

  • .toolbar if no layout is active (below the narrow breakpoint, in unoriented mode)
  • .toolbar--narrow
  • .toolbar--standard
  • .toolbar--wide
CommentFileSizeAuthor
#14 3037327-nr-bot.txt2.61 KBneeds-review-queue-bot
#10 3037327_10.patch2.17 KBathyamvidyasagar
#3 toolbar_breakpoint-3037327-3.patch1014 byteskomalk

Issue fork drupal-3037327

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

huzooka created an issue. See original summary.

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

komalk’s picture

komalk commented
Status: Active » Needs review
StatusFileSize
new toolbar_breakpoint-3037327-3.patch1014 bytes

Create the patch using media query used in toolbar.icons.theme.css same as the toolbar.standard breakpoint.
Please review the patch.

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

smustgrave’s picture

smustgrave commented
Version: 9.5.x-dev » 10.1.x-dev
Status: Needs review » Needs work
Issue tags: +Needs Review Queue Initiative, +Needs screenshots

This issue is being reviewed by the kind folks in Slack, #needs-review-queue-initiative. We are working to keep the size of Needs Review queue [2700+ issues] to around 400 (1 month or less), following Review a patch or merge request as a guide.

Would help to have before/after screenshots for the UI change. To verify nothing is broken on D10

athyamvidyasagar’s picture

athyamvidyasagar commented
StatusFileSize
new 3037327_10.patch2.17 KB

In media Query up to 0.5 is working for all browsers. Like 0.22 is not working. So media query is reset to (min-width: 38em).

shashank5563’s picture

shashank5563 commented
Status: Needs work » Needs review

@athyamvidyasagar, I have tested and reviewed. It is working fine.

shashank5563’s picture

shashank5563 commented
Status: Needs review » Reviewed & tested by the community

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3037327-nr-bot.txt2.61 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

rpayanm made their first commit to this issue’s fork.

rpayanm opened merge request !4237

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Title: Toolbar breakpoints and media query used in toolbar CSS are incoherent » 3037327-11.x

Trying to fix CCF from #10.

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Title: 3037327-11.x » Toolbar breakpoints and media query used in toolbar CSS are incoherent
rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Status: Needs work » Needs review

Please review.

smustgrave’s picture

smustgrave commented
Status: Needs review » Needs work

Previously tagged for screenshots and issue summary remaining task

Decide which one we prefer, and provide a patch (toolbar module and stable theme).

Hasn't been answered I believed. IS needs to be updated.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.