Another way (see a related issue) to export the files is to add them directly to the archive while exporting the content. The idea is taken from - a drush patch which handles not only drush commands but also takes care about the files.

However, I think that it would be better to handle the files attached to a certain entity while processing this entity, rather than export all the files together on the last batch operation call. Exporting all the files at once might be bad in terms of performance.

In the future, I plan to improve a Single Entity Export form - I want it to produce an archive with all dependent entities and the files instead of generating a raw yml text without any dependency, so being able to export only the files of a single entity would be handy in this case.

CommentFileSizeAuthor
content_sync-files_in_archive-0-D8.patch1.1 KBklimp

Comments

klimp created an issue. See original summary.

klimp’s picture

klimp
Location Montréal, QC
commented

upd: seems it doesn't work with Drupal 8.5. Because of the arguments number passed to the pack() function in Drupal\Core\Archiver\ArchiveTar->_writeHeader(). Drupal 8.5 passes 6 arguments (and complains - not enough arguments, an archive is damaged), Drupal 8.6 passes 7 arguments (fine)

A part of diff output comparing Drupal 8.6 against Drupal 8.5

$v_binary_data_first = pack(
             "a100a8a8a8a12a12",
-            $v_reduced_filename,
             $v_perms,
             $v_uid,
             $v_gid,
blanca.esqueda’s picture

blanca.esqueda commented

Thanks!

As posted in other issues, the functionality for import/export dependencies can be found in:
https://www.drupal.org/project/content_sync/issues/2873074#comment-13019230

I think we had the same ideas, I changed the part of moving all files the end weeks ago when I was working on organizing the entities by collections. The functionality to export files as the entity is being processed is almost the same as the patch you added so I credited you for the commit of that functionality (commits in content_sync Github repository are the ones that will be pushed for the next Drupal release).

  • Blanca.Esqueda committed cce273f on 8.x-2.x authored by klimp 
    Issue #3037196 by klimp, Blanca.Esqueda: Add files into the archive...
blanca.esqueda’s picture

blanca.esqueda commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.