Vocabulary name not translated in page title of the taxonomy overview and reset forms

I can confirm patch in #2 works for me.

After adding patch #2, its showing translated page title on /fr/admin/structure/taxonomy/manage/tags/overview
RTBC +1

Able tp apply patch on 9.1.x and patch works as expected. +1 for RTBC.

Applied patch #2 and it works fine.The translated vocabulary name is showing after applying this patch.

Before patch;

After patch:

As this is a bug, we need a test demonstrating that this is resolved.

Also, I don't believe this is the correct fix.

The issue here is that \Drupal\taxonomy\Controller\TaxonomyController::vocabularyTitle is not loading the correct entity context in the same way that \Drupal\Core\Entity\Controller\EntityController::title is.

I wonder if we should just use \Drupal\Core\Entity\Controller\EntityController::title instead and deprecate \Drupal\taxonomy\Controller\TaxonomyController::vocabularyTitle instead of duplicating all that code.

Fix translation issues, added test file. Available in MR395. Please review.

This looks like it's fixed with merge request 395.
The added test looks straightforward enough.

MR is showing 'custom commands failed'. Removing 'needs tests' tag since tests have been added.

Resolving phpcs issues for the further progress of the issue.

Verified and tested patch #2 for drupal 9.3.x-dev version. Patch applied successfully and looks good to me.Adding screenshot for the reference.
Need +1 RTBC

Tests are failing; also see my comment on the MR.

@joachim
Updated following points:
- Remove vocabularyTitle() method.
- Fix test cases. Test cases are passing on local now.
- Remove deprecated method calls.

Great, thanks!

Saving issue credits.

Removing credit for unneeded screenshots in #24. There were already screenshots on the issue demonstrating the fix, so a second set isn't needed. What was needed at that point was fixing phpcs errors, and reviewing the latest code changes since the previous approach. Thanks! (I've left credit for #12 as #9 did not include a "before" screenshot for comparison.)

NW for the above small points of feedback on the MR.

It would be good to also post a test-only patch or separate MR to demonstrate the test coverage of the added test.

Thanks everyone for working on this bug!

OK, addressed all of @xjm's points as best I could. Back to review!

Thanks! I think that is sufficient.

Attaching a test-only patch as per #31.

At @xjm's request, opened #3221140: Don't call mb_strtolower() when generating machine names in Taxonomy tests to deal with the (seemingly unnecessary) mb_strtolower() calls strewn across Taxonomy's test suite.

Fail patch failed. Back to RTBC.

+++ b/core/modules/taxonomy/tests/src/Functional/VocabularyTranslationTest.php
@@ -55,4 +70,50 @@ public function testVocabularyLanguage() {
+    // Assert that the name label is displayed on the translation form with the right value.
...
+    // Assert that the right name label is displayed on the taxonomy term overview page. The
+    // translations are created in this test; therefore, the assertions do not
+    // use t(). If t() were used then the correct langcodes would need to be
+    // provided.
...
+    // Assert that the right name label is displayed on the taxonomy reset page. The
+    // translations are created in this test; therefore, the assertions do not
+    // use t(). If t() were used then the correct langcodes would need to be
+    // provided.

Ahoy, this is what happens when we use GitLab's UI and don't have the 80-character line anymore. These comments need to be rewrapped.

Done. Since it's literally just whitespace changes, restoring RTBC.

There was another 80-char thing which I thought we had a rule for, which is the array multiline format. Multivalue arrays are supposed to be put on multiple lines if the line is over 80:

diff --git a/core/modules/taxonomy/tests/src/Functional/VocabularyTranslationTest.php b/core/modules/taxonomy/tests/src/Functional/VocabularyTranslationTest.php
index f36bd973c7..ac321c34cb 100644
--- a/core/modules/taxonomy/tests/src/Functional/VocabularyTranslationTest.php
+++ b/core/modules/taxonomy/tests/src/Functional/VocabularyTranslationTest.php
@@ -14,7 +14,11 @@ class VocabularyTranslationTest extends TaxonomyTestBase {
   /**
    * {@inheritdoc}
    */
-  protected static $modules = ['content_translation', 'language', 'config_translation'];
+  protected static $modules = [
+    'content_translation',
+    'language',
+    'config_translation',
+  ];
 
   /**
    * {@inheritdoc}

That was straightforward enough to fix on commit. Committed to 9.3.x only since it introduces a deprecation for an internal API. Thanks!

Closed https://www.drupal.org/project/drupal/issues/2924408 as a duplicate of this. Moved over credit.