Type hint "array" missing [#3036558]

Comment	File	Size	Author
#8	interdiff_6-8.txt	1.12 KB	mukesh88
#8	3036558-8.patch	4.24 KB	mukesh88
#6	3036558-6.patch	3.85 KB	_pratik_
#6	interdiff_3036558.txt	1.34 KB	_pratik_
#2	entity-browser-array-3036558.patch	3.28 KB	jigish.addweb

Comment #1

28 February 2019 at 18:15

jigish.addweb created an issue. See original summary.

Log in or register to post comments

Comment #2

jigish.addweb commented 28 February 2019 at 18:17

Status	File	Size
new	entity-browser-array-3036558.patch	3.28 KB

Here's the patch on the same kindly review it.

Log in or register to post comments

Comment #3

oknate

Greater New York City Area

commented 28 February 2019 at 20:41

Status:

Active

» Needs review

Please change ticket status to "Needs Review" when you would like review.

Log in or register to post comments

Comment #4

indrapatil commented 7 February 2023 at 11:17

Assigned:

Unassigned

» indrapatil

I am reviewing the patch.

Log in or register to post comments

Comment #5

indrapatil commented 7 February 2023 at 11:24

Assigned:	indrapatil	» Unassigned
Status:	Needs review	» Needs work

The patch was applied successfully. but still, I can see the errors
/entity_browser/src/Plugin/views/filter/ContextualBundle.php
---------------------------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
---------------------------------------------------------------------------------------------------
53 | ERROR | Parameter $selection_storage is not described in comment
198 | ERROR | Type hint "array" missing for $input
---------------------------------------------------------------------------------------------------

So moving to Needs work.