CommentFileSizeAuthor
#21 3035591-nr-bot.txt171 bytesneeds-review-queue-bot
#3 admin_menu_vertical_issue.png501.69 KBmcannon
#4 toolbar-unclickables_fix-3035591-4.patch3.84 KBhuzooka
#5 toolbar-unclickables_fix-3035591-5.patch1.6 KBmcannon
#7 Screen Shot 2019-02-28 at 21.47.06.png52.34 KBlauriii
#8 admin_menu_vertical_issue_2.png511.47 KBmcannon
#10 admin_menu_vertical_issue_3.png960.42 KBmcannon
#12 after.png472.9 KBkomalk
#12 before.png466.31 KBkomalk
#12 toolbar-unclickables_fix-3035591-12.patch4.32 KBkomalk
#12 interdiff-3020422-4-12.txt943 byteskomalk
#14 toolbar-unclickables_fix-3035591-12.patch4.32 KBkomalk
#15 vertical-toolbar-after-patch.png32.54 KBBalajiDS
#15 vertical-toolbar-before-patch.png81.19 KBBalajiDS

Comments

huzooka created an issue. See original summary.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: Unassigned » huzooka
mcannon’s picture

mcannon commented
StatusFileSize
new admin_menu_vertical_issue.png501.69 KB

@huzooka,

Is this the issue described in this ticket?
Admin Menu Screenshot

As I explain in the screenshot, the "Vertical/Horizontal" toggle button only shows because I tweaked the styles in the browser. If this is the issue, I already have it done in the browser and can quickly convert that to a patch.

huzooka’s picture

huzooka
Primary language Hungarian
Location Hungary 🇭🇺🇪🇺
commented
Assigned: huzooka » Unassigned
Status: Active » Needs review
StatusFileSize
new toolbar-unclickables_fix-3035591-4.patch3.84 KB

Hi @mcannon, yes, however I need a flexible fix.
Check out this patch!

mcannon’s picture

mcannon commented
StatusFileSize
new toolbar-unclickables_fix-3035591-5.patch1.6 KB

@huzooka,

I tested your patch & it works as intended. I just don't see the need to change any of the javascript when it can all be done more reliably with pure CSS. I've uploaded a patch that fixes this with just 5 lines of CSS added to the "toolbar" module and the "stable" theme.

pratik.mehta19’s picture

pratik.mehta19 commented
Status: Needs review » Reviewed & tested by the community
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Issue summary: View changes
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new Screen Shot 2019-02-28 at 21.47.06.png52.34 KB

The most recent patch doesn't fix it for me 🤔

mcannon’s picture

mcannon commented
StatusFileSize
new admin_menu_vertical_issue_2.png511.47 KB

@lauriii,

Can you supply more detail about how you saw the issue remain: OS, Browser, Cleared Cache, etc...

Here's a screenshot of what I see in OS X, Chrome with iPad emulator enabled. I see these styles:
Screenshot 2

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented

I tested this on OS X, Chrome using responsive mode with resolution 1121 x 291. I can see that the styles get added to the element from the CSS developer tool.

mcannon’s picture

mcannon commented
StatusFileSize
new admin_menu_vertical_issue_3.png960.42 KB

@lauriii,

I tested this again based on your details and I still see the bottom icon. Is there possible another issue? Or something I didn't try to replicate the same issue?

Screenshot 3

Version: 8.6.x-dev » 8.8.x-dev

Drupal 8.6.x will not receive any further development aside from security fixes. Bug reports should be targeted against the 8.8.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.9.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

komalk’s picture

komalk commented
Status: Needs work » Needs review
StatusFileSize
new after.png472.9 KB
new before.png466.31 KB
new toolbar-unclickables_fix-3035591-12.patch4.32 KB
new interdiff-3020422-4-12.txt943 bytes
komalk’s picture

komalk commented
komalk’s picture

komalk commented
StatusFileSize
new toolbar-unclickables_fix-3035591-12.patch4.32 KB
BalajiDS’s picture

BalajiDS commented
Issue summary: View changes
StatusFileSize
new vertical-toolbar-before-patch.png81.19 KB
new vertical-toolbar-after-patch.png32.54 KB

Patch #14 working fine in Drupal - 8.8.6

Version: 8.8.x-dev » 8.9.x-dev

Drupal 8.8.7 was released on June 3, 2020 and is the final full bugfix release for the Drupal 8.8.x series. Drupal 8.8.x will not receive any further development aside from security fixes. Sites should prepare to update to Drupal 8.9.0 or Drupal 9.0.0 for ongoing support.

Bug reports should be targeted against the 8.9.x-dev branch from now on, and new development or disruptive changes should be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 8.9.x-dev » 9.2.x-dev

Drupal 8 is end-of-life as of November 17, 2021. There will not be further changes made to Drupal 8. Bugfixes are now made to the 9.3.x and higher branches only. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.15 was released on June 1st, 2022 and is the final full bugfix release for the Drupal 9.3.x series. Drupal 9.3.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.4.x-dev branch from now on, and new development or disruptive changes should be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.9 was released on December 7, 2022 and is the final full bugfix release for the Drupal 9.4.x series. Drupal 9.4.x will not receive any further development aside from security fixes. Drupal 9 bug reports should be targeted for the 9.5.x-dev branch from now on, and new development or disruptive changes should be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Needs review » Needs work
StatusFileSize
new 3035591-nr-bot.txt171 bytes

The Needs Review Queue Bot tested this issue. It either no longer applies to Drupal core, or fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

Apart from a re-roll or rebase, this issue may need more work to address feedback in the issue or MR comments. To progress an issue, incorporate this feedback as part of the process of updating the issue. This helps other contributors to know what is outstanding.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

Version: 9.5.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.

quietone’s picture

quietone commented
Status: Needs work » Postponed

The Toolbar Module was approved for removal in #3476882: [Policy] Move Toolbar module to contrib.

This is Postponed. The status is set according to two policies. The Remove a core extension and move it to a contributed project and the Extensions approved for removal policies.

The deprecation work is in #3484850: [meta] Tasks to deprecate Toolbar module and the removal work in #3488828: [meta] Tasks to remove Toolbar module.

Toolbar will be moved to a contributed project before Drupal 12.0.0 is released.