Problem/Motivation

In splashify_init(), the variable $js_expiretime is initialized as an empty string. Later, that variable is used in a context where a numeric value is expected. In practice this issue will affect only sites with a custom code interacting with Splashify since it will occur only if the variable 'splashify_when_mobile_frequency' is set to a value other than the expected ones.

Proposed resolution

Initialize the variable as a number (0) rather than an empty string.

Remaining tasks

User interface changes

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#2 3035182-splashify-php_notice-2.patch467 bytesdalin

Comments

dalin created an issue. See original summary.

dalin’s picture

Issue summary: View changes
Status: Active » Needs review
StatusFileSize
new467 bytes
nedjo’s picture

Title: Warning: A non-numeric value encountered in splashify_init() with "session" frequency » Variable $js_expiretime initialized as string rather than number
Priority: Normal » Minor
Issue summary: View changes

From the original report:

If splashify_when_desktop_frequency is set to session

This occurs only if the patch from #2516940: Create a Session only option for the splash page or similar is in place. Updating issue summary accordingly.

astonvictor’s picture

Status: Needs review » Closed (outdated)

D7 reached its EOL back in January 2025, and there is no active release for D7 for this module anymore.
Development or support is not planned for D7. All D7-related issues are marked as outdated in a bunch.

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.