Hello,
Here's a form which have close date/time and has captcha.
This form has expired. I can see the message I specified (form closed message) but still there is the captcha challange.
Please find attached screenshoot.
(webform 8.x-5.1)

CommentFileSizeAuthor
#9 3035054-10.patch13.96 KBjrockowitz
#8 3035054-8.patch11.79 KBjrockowitz
#6 3035054-6.patch11.21 KBjrockowitz
#5 3035054-5.patch3.88 KBjrockowitz
#4 Contact Webform Demo Site.png337.85 KBjrockowitz
#4 3035054-4.patch1.12 KBjrockowitz
my_form_expired.jpg27.33 KBkepesv

Comments

kepesv created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented

Are you adding the CAPTCHA as a webform element? or as a global behavior (/admin/config/people/captcha/captcha-points)?

kepesv’s picture

kepesv commented

As global behavior.
I've just tried as element now, it is a new - previously unknown - way for me I can add a captcha to the form .
This is solved the problem, thank you for the hint, You are Great.
Even so I think it could be useful for many people if it could be working properly as global behavior too.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3035054-4.patch1.12 KB
new Contact Webform Demo Site.png337.85 KB

I am not seeing any easy to fix this problem. The only immediate solution I can think of is adding a warning to the CAPTCHA placement details.

jrockowitz’s picture

jrockowitz commented
Status: Active » Needs review
StatusFileSize
new 3035054-5.patch3.88 KB

Because a webform attached to nodes can have multiple form IDs (one for each node) it makes more sense to encourage everyone to add a CAPTCHA element to a webform instead of a CAPTCHA point.

The attached patch replaces the CAPTCHA module's link with an add/edit a webform specific CAPTCHA element.

This approach is going to require a change record.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3035054-6.patch11.21 KB

Status: Needs review » Needs work

The last submitted patch, 6: 3035054-6.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

jrockowitz’s picture

jrockowitz commented
Status: Needs work » Needs review
StatusFileSize
new 3035054-8.patch11.79 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3035054-10.patch13.96 KB

Here is the final patch.

  • jrockowitz committed 7be129e on 8.x-5.x 
    Issue #3035054 by jrockowitz, kepesv: Captcha challenge still visible...
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

I committed the patch. Please download the latest dev release to review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.