Problem/Motivation
When Drupal is installed in a foreign language or a foreign language is added on top of the English language in an install profile, Drupal imports translations. This results in two sizeable feedback messages in some cases. If all translations were imported well, some stats are reported, and if there was some format error in even one single string out of the several thousands imported, then an error is also printed.
While this reporting makes sense when a new language is added on the UI, displaying them as part of the installation process seems like too much detail. We don't display stats about config imported or modules enabled, etc. The warning (if shown) is also something the user cannot do anything about as it is about broken HTML in the .po file downloaded. The warning also makes the actual settings.php warning harder to notice and act on, causing warning fatigue.

Proposed resolution
Avoid user facing messages for imported translations except for the case of entirely missing translation files. The logging of the messages that are not displayed should still be intact.
Remaining tasks
Implement properly.
User interface changes
Reporting messages and warnings about invalid HTML strings will not display anymore in the installer.
API changes
No API changes. The proposed implementation fixes the finish_feedback option on locale batches to work according to its documentation and silence user messages (while still keeping logging intact).
Data model changes
None.
Release notes snippet
N/A.
| Comment | File | Size | Author |
|---|---|---|---|
| #10 | interdiff_7-10.txt | 1.56 KB | shaal |
| #10 | ootb-too-much-details-in-installer-3034784-10.patch | 10.23 KB | shaal |
| #7 | no-translated-string-errors-after-installation.png | 372.39 KB | shaal |
| #7 | no-translated-string-errors-during-installation.png | 375.12 KB | shaal |
| #7 | ootb-too-much-details-in-installer-3034784-7.patch | 10.3 KB | shaal |
Comments
Comment #2
gábor hojtsyBring part of the patch from #3029839: Multilingual functionality - enable English and Spanish as part of Umami installation here, so it can be worked on independently.
Comment #5
webchickThis introduced a rather large UX regression in the installer, so raising priority to major and tagging hopefully as an RC target.
Those error messages persist through another ~8 minutes of the installer that comes after this page, too, as the translations get into place. The "2 translation strongs were skipped" warning in particular would be great to get rid of it we can; the green message is noisy but it's green so can be safely ignored.
Comment #6
shaalAdditional bug (I don't know if this bug requires a separate issue, or if this is the issue that will resolve this bug as well) -
During the Umami installation process, if the user is typing a certain password but types a different password in the "confirm password" field, an error is displayed:
The specified passwords do not match.(which is good and expected)
The problem appears when the installation process continues, and that password error is still displayed (it is not relevant anymore, because to get to this stage the user must have typed the same password and confirmed password).

The problem continues when the installation is completed, and on the first page of Umami that the user is seeing - that same irrelevant error of mismatched passwords appears again.

Comment #7
shaal(interdiff was not possible)
Rerolled patch #2, and added a check if the array exist in lines #394 and #404:
from:
if ($results['finish_feedback']) {to this:
if (isset($results['finish_feedback']) && $results['finish_feedback']) {After applying this patch here are the new screenshots -
During installation:

After installation completed:

Comment #9
shaalComment #10
shaalI removed the extra
issetI added in #7, since it only camouflage and hide a warning during installation but doesn't resolve the actual problem.Warning messages during installation using
drush si demo_umami:Additional insights from Slack channel after I asked for a hint about the 35 failed tests in #7:
@Gábor Hojtsy:
I vaguely remember when I worked on it I figured there are three kinds of batches from two files that are related and would need the same fix to be consistent. That is where it got real ugly because we need to add the same batch function at multiple places given the slightly different batch building in include files.
@alexpott
Yep what @Gábor Hojtsy is saying looks correct… something is going wrong in one of the places where the batch is being built.
Comment #11
smazComment #19
nlisgo commentedCan someone confirm that this is an issue with 11.x? It has been 6 years since this was last confirmed.
Comment #20
nlisgo commentedComment #21
gábor hojtsyI don't think anything changed with this in the meantime.
Comment #22
catchComment #23
smustgrave commentedThis came around again as a daily BSI target
This seems more like a task vs a bug
Sure with things moving to OOP functions this will need a good amount of work.