CommentFileSizeAuthor
#13 interdiff-13.txt3.74 KBamateescu
#13 3034757-13.patch5.92 KBamateescu
#11 3034757-11.patch2.18 KBshubham.prakash
#9 3034757-9.patch2.18 KBshubham.prakash
#7 deprecated_assertequal_removed-3034757-7.patch2.26 KBsahana _n
#4 deprecated_assertequal_removed-3034757-4.patch2.18 KBsahana _n
#2 Remove-calls-to-deprecated-method-assertEqual-3034757-2.patch2.18 KBshruthi_shetty

Comments

Shruthi Shetty M created an issue. See original summary.

shruthi_shetty’s picture

shruthi_shetty commented
Status: Active » Needs review
StatusFileSize
new Remove-calls-to-deprecated-method-assertEqual-3034757-2.patch2.18 KB

Removed calls to deprecated method assertEqual() and replaced it with assertEquals().

idebr’s picture

idebr commented
Status: Needs review » Needs work

The arguments for $actual, $expected are inverted between ::assertEqual() and ::assertEqual(), so the test assertions should be swapped as well.

sahana _n’s picture

sahana _n commented
StatusFileSize
new deprecated_assertequal_removed-3034757-4.patch2.18 KB

removed deprecated method please review

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 4: deprecated_assertequal_removed-3034757-4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

sahana _n’s picture

sahana _n commented
Status: Needs work » Needs review
StatusFileSize
new deprecated_assertequal_removed-3034757-7.patch2.26 KB

removed deprecated method please review

Status: Needs review » Needs work

The last submitted patch, 7: deprecated_assertequal_removed-3034757-7.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

shubham.prakash’s picture

shubham.prakash commented
Status: Needs work » Needs review
StatusFileSize
new 3034757-9.patch2.18 KB

Hope this patch fixes the issue.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Needs work 
+++ b/tests/src/Kernel/PathautoTokenTest.php
@@ -38,7 +38,7 @@ class PathautoTokenTest extends KernelTestBase {
     $alias_cleaner = \Drupal::service('pathauto.alias_cleaner');
     $alias_cleaner->cleanTokenValues($replacements, $data, []);
-    $this->assertEqual($replacements['[array:join-path]'], 'test-first-arg/array-value');
+    $this->assertEquals($replacements['[array:join-path]'], 'test-first-arg/array-value');

the arguments here need to be inverted too.

shubham.prakash’s picture

shubham.prakash commented
Status: Needs work » Needs review
StatusFileSize
new 3034757-11.patch2.18 KB

This patch should fix the issue.

ravi.shankar’s picture

ravi.shankar commented
Status: Needs review » Reviewed & tested by the community
amateescu’s picture

amateescu commented
StatusFileSize
new 3034757-13.patch5.92 KB
new interdiff-13.txt3.74 KB

The patch is missing the most important part mentioned in the issue title: the conversion of assertEqual() to assertEquals() or equivalent methods.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Thanks, fixed some spacing and case problems on commit.

  • Berdir committed 055a35a on 8.x-1.x authored by amateescu 
    Issue #3034757 by Sahana _N, shubham.prakash, amateescu, Shruthi Shetty...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.