The [invalidations:separated_pipe], [invalidations:separated_comma] & [invalidations:separated_tab] tokens create a string with cache tags. Currently the resulting string can contain the same cache tag multiple times (eg. node_list|node:123|node_list|node:456|node:789|node_list). Patch attached removes these duplicate tags.

CommentFileSizeAuthor
#4 3034525-4.patch663 byteswilleaton
purge-tokens_duplicate_cache_tags-1.patch550 bytesrp7

Comments

rp7 created an issue. See original summary.

rp7’s picture

rp7 commented
Title: Clean up duplicate cache tags c reated by invalidation tokens » Clean up duplicate cache tags created by invalidation tokens
ndobromirov’s picture

ndobromirov commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +scalability, +Performance

Solution seems OK and simple enough to RTBC.
You might want to check #2952277: Minify the cache tags sent in the header as well.

willeaton’s picture

willeaton commented
StatusFileSize
new 3034525-4.patch663 bytes

If you already have the patch applied for #2952277: Minify the cache tags sent in the header then the above patch cannot apply. I include a patch which is compatible with aforementioned issue

japerry’s picture

japerry
Location KOMK
commented
Issue tags: +purge-3.1

Rerolled and applied to 3.1 branch

  • nielsvm committed e376410 on 8.x-3.x authored by willeaton 
    Issue #3034525: Clean up duplicate cache tags created by invalidation...
nielsvm’s picture

nielsvm commented
Status: Reviewed & tested by the community » Fixed

Merged, thank you for your contributions!

https://www.drupal.org/project/purge/issues/3236847

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.