I seem to be able to submit invalid info using the autofill (I'm using chrome Version 71.0.3578.98 on a mac) that comes up when I select previously input data during filling out the form. I appreciate this might be beyond the capabilities of webform to get round this. In my previously entered data I have a phone number starting with a 0 (which is what you would type when phoning someone in the uk, from the uk), if I start to change it it correctly suggests it's invalid as I need to remove this 0, but with it filled in incorrectly I can go ahead and submit the form (well in my case go to the next page in the wizard), by doing so the phone number in the results has the 0 stripped, but no +44 (uk code) added. If I change it by removing the 0 it appears correctly with the +44.
I'm using the using the jQuery International Telephone Input plugin.

CommentFileSizeAuthor
#8 3034377-8.patch11.29 KBjrockowitz
#7 3034377-6.patch9.11 KBjrockowitz
#5 ScreenFlow.gif477.01 KBjrockowitz
#5 3034377-5.patch3.82 KBjrockowitz
#3 3034377-2.patch3.94 KBjrockowitz

Comments

benjarlett created an issue. See original summary.

jrockowitz’s picture

jrockowitz commented
Priority: Minor » Normal
Status: Active » Needs review

The Webform module does not include any server-side validation for telephone numbers.

The attached patch adds very preliminary support for the Telephone Validation module. Please try it out an provide feedback.

BTW, the jQuery International Telephone library might still have a bug that should be resolved in the upstream code.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3034377-2.patch3.94 KB
benjarlett’s picture

benjarlett commented

Thanks for trying Jacob. I tried it... sadly it still allowed me to submit a telephone number of 7799000999 when chrome filled it in for me.

jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3034377-5.patch3.82 KB
new ScreenFlow.gif477.01 KB

@benjarlett Did you install and enable the telephone validation module?

Below is the server-side validation error I am seeing when the form is submitted with 7799000999 chrome's autofill. The jQuery International Telephone library would have to update to fix the client-side validation issue.

The attached patch just fixes a minor bug.

  • jrockowitz committed b348222 on 8.x-5.x 
    Revert "Issue #3034377 by jrockowitz: Telephone number"

This reverts...
  • jrockowitz committed c4bbcba on 8.x-5.x
    Issue #3034377 by jrockowitz: Telephone number
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3034377-6.patch9.11 KB
jrockowitz’s picture

jrockowitz commented
StatusFileSize
new 3034377-8.patch11.29 KB

  • jrockowitz committed 8e18c0a on 8.x-5.x 
    Issue #3034377 by jrockowitz: Telephone number
jrockowitz’s picture

jrockowitz commented
Status: Needs review » Fixed

I committed the patch. Please download the latest dev release to review.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

vasanthanand’s picture

vasanthanand commented

Hi @jrockowitz ,

I am using jQuery International Telephone Input plugin and the issue still exist that it allows submission even after the invalid phone number provided. Is there a patch available for it.

Please help me in getting it resolved.

Thank you so much in advance.

Regards.
Vasanth

jrockowitz’s picture

jrockowitz commented

Are you using the latest dev release of the Webform module?

Did you install and enable the Telephone validation module?