Closed (fixed)
Project:
Social Auth Facebook
Version:
8.x-2.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
18 Feb 2019 at 08:10 UTC
Updated:
11 Jun 2019 at 00:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
miteshmapComment #3
miteshmapComment #4
gvsoCan we somehow include this logic in Social Auth itself? It would be applicable to all other modules as well.
Comment #5
miteshmapwe can add event dispatcher to social_auth module and user event subscriber here, but we need something in each social auth sub module, because each social site has different way to notify error.
Or on the second thought, we need event dispatcher in all social auth sub module and event subscriber in social_auth module, to handle the redirection part.
Comment #6
gvsoIn case of error, I think we can just call a function defined in Social Auth which takes care of dispatching the event and providing the error information. It is up to the event subscriber to handle the different errors that the implementers might throw. See my last comment in the related issue.
Comment #7
miteshmapComment #8
miteshmapComment #9
miteshmapUpdating according to the latest changes in - https://www.drupal.org/project/social_auth/issues/3033749#comment-13104502
Comment #10
miteshmapComment #11
gvsoComment #12
gvsoComment #14
gvsoI made some changes to make the code a bit simpler and pass the error to the event handler. Thank you! I hope this helps with your project!
Comment #15
gvso