Hello,

I'm using In-Place Editor to add/remove panes. Also it used for changing styles of panes. I created own style plugin which provides some settings and everything is ok at this step. But there is a problem when I change style of pane from own style which provides settings to some other default style which does't provide any settings (for example System block). Right after saving and reloading page I see notice:

Notice: Undefined index: settings in panels_renderer_standard->render_pane() (line 572 of panels/plugins/display_renderers/panels_renderer_standard.class.php).

It hapens because IPE class makes unset($pane->style['settings']), but render class expects it.

Steps to reproduce:

  • Install latest drupal 7 using default profile
  • Enable page_manager + panels_ipe + all dependencies
  • Enable attached example module. The module contains example style plugin with settings for pane
  • Create a custom page using page manager (you can use any layout, title and path)
  • Use "In-Place Editor" as renderer for panel
  • Add "Who's online" pane to the any column and save panel
  • Go to the created panel and start modify it using IPE (click on "Customize this page" at the bottom of the page)
  • Modify a style of the "Who's online" pane
  • Change the style from "No style" to the "Example"
  • Write any value into "Some setting" field on the setting form
  • Save changes and refresh a page. The value of the setting has to displayed after "Who's online" pane
  • Modify a style of the "Who's online" pane again and change it to the "Rounded corners". Save changes and refresh a page. Notice is appear

Note: I attached a screencast to demonstrate a problem. The example style also is attached

CommentFileSizeAuthor
#7 screencast 2020-06-26 14-56-15.mp442.16 MBzestagio
#7 example.tar_.gz752 byteszestagio
#2 panels-notice-undefined-index-settings-in-panels_renderer_standard-3032350-2-D7.patch686 byteszestagio

Comments

zestagio created an issue. See original summary.

zestagio’s picture

zestagio commented
Status: Active » Needs review
StatusFileSize
new panels-notice-undefined-index-settings-in-panels_renderer_standard-3032350-2-D7.patch686 bytes
lmakarov’s picture

lmakarov
Location Seattle
commented
Status: Needs review » Reviewed & tested by the community

Can confirm the patch in #2 works. A simple fix for a long standing, annoying issue. Thanks!

lmakarov’s picture

lmakarov
Location Seattle
commented
Status: Reviewed & tested by the community » Closed (cannot reproduce)

Reverting back to Needs Review, as the notice came back after additional testing.

The actual source of the issue (in my case) was in the way the custom style was applied by default to all new panes:

function mymodule_panels_new_pane_alter(&$pane) {
  $pane->style['style'] = 'custom_style';
}

The fix was to set the $pane->style['settings'] value to an empty array:

function mymodule_panels_new_pane_alter(&$pane) {
  $pane->style['style'] = 'custom_style';
  $pane->style['settings'] = array();
}

Also, I was not able to reproduce the issue by setting pane style to System block or No style, so the patch #2 seems to be unnecessary.

lmakarov’s picture

lmakarov
Location Seattle
commented
Status: Closed (cannot reproduce) » Needs review
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Postponed (maintainer needs more info)

Could you provide steps to reproduce the bug?

zestagio’s picture

zestagio commented
Issue summary: View changes
StatusFileSize
new example.tar_.gz752 bytes
new screencast 2020-06-26 14-56-15.mp442.16 MB
zestagio’s picture

zestagio commented
Status: Postponed (maintainer needs more info) » Needs review

I updated a description and provided steps to reproduce

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Parent issue: » #2850154: Plan for Panels 7.x-3.10

Nice work on the steps and video was awesome @zestagio! I'll dig into this shortly and likely commit something before the next release (soon)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

@zestagio, I tried to reproduce the steps just now and couldn't get that error to show up, so I'll watch the video and see if I can glean the problem from that.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Ah I had caching turned on which quells the problem, I'm able to see the issue now.

  • joelpittet committed f691705 on 7.x-3.x authored by zestagio 
    Issue #3032350 by zestagio, joelpittet, lmakarov: Notice: Undefined...
joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Needs review » Fixed

I appreciate the hard work digging to the bottom of the bug. I've committed it to the dev for the imminent release of 3.10

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.