Problem/Motivation

Select2 integration with Facets does not work properly when AJAX Facets widgets are used.

Proposed resolution

As maintainer would propose it:

Fix it!

Jokes aside.

1. To integrate that nicely in combination with Facets we should first provide some kind of JavaScript API for Facets and then use it.
There is a proposal for such JS API in Facets here: #3031581: Provide JavaScript API for facet widgets

2. And then adjust select2 facets integration to use that API instead of handling filtering logic on its own.

Comments

mtodor created an issue. See original summary.

mtodor’s picture

mtodor commented
Status: Active » Needs review

There is PR for this: https://github.com/thunder/select2/pull/54

chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Title: Support for AJAX Fecets » Support for AJAX Facets
ytsurk’s picture

ytsurk
Location Switzerland
commented

Looks good to me so far.

THX

Maybe we could allow to pass in custom select2-options ('#select2') for every facet, right now only width is there as an argument ?

  • chr.fritsch committed de8c784 on 8.x-1.x authored by mtodor 
    Issue #3031587 by mtodor, chr.fritsch: Support for AJAX Facets
chr.fritsch’s picture

chr.fritsch
he/him
Primary language German
Location 🇩🇪🇪🇺🌍
commented
Status: Needs review » Fixed

@ytsurk: It sounds like your comment is not related to this issue. Can you please open a follow-up, where we can discuss passing in more options to the facet.

Other than that. I committed this PR.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.