When running drush potx single --modules=entity_browser --api=8 --language=nl the following error occurs:

The first parameter to t() should be a literal string. There should be no variables, concatenation, constants or other non-literal strings there. At t($this->configuration['select_text']) in modules/contrib/entity_browser/src/Plugin/EntityBrowser/SelectionDisplay/MultiStepDisplay.php on line 160. Read more at http://drupal.org/node/322732

CommentFileSizeAuthor
#9 3031433_9.patch1.17 KBmpp
#6 3031433_5.patch1.19 KBmpp
#4 3031433_4.patch698 bytesmpp

Comments

mpp created an issue. See original summary.

mpp’s picture

mpp commented
Issue summary: View changes
mpp’s picture

mpp commented
Title: potx translations are broken on localize.drupal.org » Fix invalid translation for select_text configuration
Issue summary: View changes
Priority: Critical » Minor
mpp’s picture

mpp commented
Status: Active » Needs review
StatusFileSize
new 3031433_4.patch698 bytes

Status: Needs review » Needs work

The last submitted patch, 4: 3031433_4.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mpp’s picture

mpp commented
StatusFileSize
new 3031433_5.patch1.19 KB

The schema key should be marked as translatable.

mpp’s picture

mpp commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 6: 3031433_5.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mpp’s picture

mpp commented
Status: Needs work » Needs review
StatusFileSize
new 3031433_9.patch1.17 KB

Testing with a different type.

Status: Needs review » Needs work

The last submitted patch, 9: 3031433_9.patch, failed testing. View results
- codesniffer_fixes.patch Interdiff of automated coding standards fixes only.

mpp’s picture

mpp commented
Status: Needs work » Needs review
mpp’s picture

mpp commented
Status: Needs review » Closed (duplicate)

Closing in favor of https://www.drupal.org/project/entity_browser/issues/2675390